Date: Thu, 9 May 2019 19:13:35 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg12 release notes
Message-ID: <20190510001335.GJ3925@telsasoft.com>
References: <20190508203204.GA25482@telsasoft.com>
 <20190509233518.gqaelz5zao4jcznx@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="eMnpOGXCMazMAbfp"
Content-Disposition: inline
In-Reply-To: <20190509233518.gqaelz5zao4jcznx@momjian.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--eMnpOGXCMazMAbfp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 09, 2019 at 07:35:18PM -0400, Bruce Momjian wrote:
> I have made your other changes, with adjustment, patch attached.
> 
> The results are here:
> 
> 	http://momjian.us/pgsql_docs/release-12.html

Thanks

> -Many system tables now have an 'oid' column that will be expanded with
> -SELECT * by default.
> +The many system tables with such columns will now display those columns
> +with SELECT * by default.

I think "The many" is hard to parse but YMMV.

Find attached additional changes from another pass I've made.


From 97ddf06bc9221153c52613b8c840409ee698bbad Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 14:15:57 -0500
Subject: [PATCH v2 1/2] pg12 relnotes v2

---
 doc/src/sgml/release-12.sgml | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index ab4d1b3..cc48960 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -127,7 +127,7 @@ Author: Peter Eisentraut <peter@eisentraut.org>
 -->
 
 <para>
-Cause recovery to recover to the latest timeline by default (Peter Eisentraut)
+Cause recovery to advance to the latest timeline by default (Peter Eisentraut)
 </para>
 
 <para>
@@ -205,7 +205,8 @@ Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
 -->
 
 <para>
-Require pg_restore to use "-f -" to output the dump contents to stdout (Euler Taveira)
+Require specification of "-f -" to cause pg_restore to write to stdout (Euler
+Taveira)
 </para>
 
 <para>
@@ -1003,7 +1004,7 @@ Allow logging of only a percentage of statements and transactions meeting log_mi
 </para>
 
 <para>
-The parameters log_statement_sample_rate and log_transaction_sample_rate control this.
+This is controlled by the new parameters log_statement_sample_rate and log_transaction_sample_rate.
 </para>
 </listitem>
 
@@ -1076,7 +1077,7 @@ Add tracking of global objects in system view pg_stat_database (Julien Rouhaud)
 </para>
 
 <para>
-The system view row's datoid is reported as zero.
+The system wide objects are shown with a datoid of zero.
 </para>
 </listitem>
 
@@ -1132,7 +1133,8 @@ Author: Peter Eisentraut <peter@eisentraut.org>
 -->
 
 <para>
-Allow viewers of pg_stat_ssl to only see their own rows (Peter Eisentraut)
+Restrict visibility of rows in pg_stat_ssl by unprivileged users (Peter
+Eisentraut)
 </para>
 </listitem>
 
@@ -1216,7 +1218,8 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
 -->
 
 <para>
-Allow more comparisons with information_schema text columns to use indexes (Tom Lane)
+Allow use of indexes for more comparisons with text columns of
+information_schema (Tom Lane)
 </para>
 </listitem>
 
@@ -1280,7 +1283,8 @@ Author: Magnus Hagander <magnus@hagander.net>
 -->
 
 <para>
-Allow the clientcert pg_hba.conf option to check the database user name matches the certificate common name (Julian Markwort, Marius Timmer)
+Allow the clientcert pg_hba.conf option to check that the database user name
+matches the certificate common name (Julian Markwort, Marius Timmer)
 </para>
 
 <para>


From f9d2ee1232090d9087f110d3299bdfae3ed2eab9 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 18:50:42 -0500
Subject: [PATCH v2 2/2] Add commas: "Previously,"

---
 doc/src/sgml/release-12.sgml | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index cc48960..3f9893e 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -115,7 +115,7 @@ Do not allow multiple different recovery_target* specifications (Peter Eisentrau
 </para>
 
 <para>
-Previously multiple different recovery_target* variables could be specified, and the last one specified was honored.  Now, only one can be specified, though the same one can
+Previously, multiple different recovery_target* variables could be specified, and the last one specified was honored.  Now, only one can be specified, though the same one can
 be specified multiple times and the last specification is honored.
 </para>
 </listitem>
@@ -183,7 +183,7 @@ Change XML functions like xpath() to never pretty-print their output (Tom Lane)
 </para>
 
 <para>
-Previously this happened in some rare cases.  ACCURATE?  HOW TO GET PRETTY PRINT OUTPUT?
+Previously, this happened in some rare cases.  ACCURATE?  HOW TO GET PRETTY PRINT OUTPUT?
 </para>
 </listitem>
 
@@ -384,7 +384,7 @@ Allow partitions bounds to be any expression (Kyotaro Horiguchi, Tom Lane, Amit
 </para>
 
 <para>
-Expressions are evaluated at table partitioned table creation time.  Previously only constants were allowed as partitions bounds.
+Expressions are evaluated at table partitioned table creation time.  Previously, only constants were allowed as partitions bounds.
 </para>
 </listitem>
 
@@ -515,7 +515,7 @@ Allow parallel query when in SERIALIZABLE ISOLATION MODE (Thomas Munro)
 </para>
 
 <para>
-Previously parallelism was disabled when in this mode.
+Previously, parallelism was disabled when in this mode.
 </para>
 </listitem>
 
@@ -793,7 +793,7 @@ Store statistics using the collation defined for each column (Tom Lane)
 </para>
 
 <para>
-Previously the default collation was used for all statistics storage.  This potentially gives better optimizer behavior for columns with non-default collations.
+Previously, the default collation was used for all statistics storage.  This potentially gives better optimizer behavior for columns with non-default collations.
 </para>
 </listitem>
 
@@ -1532,7 +1532,7 @@ Allow the streaming replication timeout to be set per connection (Tsunakawa Taka
 </para>
 
 <para>
-Previously this could only be set cluster-wide.
+Previously, this could only be set cluster-wide.
 </para>
 </listitem>
 
@@ -1825,7 +1825,7 @@ Use all column names when creating default foreign key constraint names (Peter E
 </para>
 
 <para>
-Previously only the first column name was used.
+Previously, only the first column name was used.
 </para>
 </listitem>
 
@@ -2329,7 +2329,7 @@ Allow control of log file rotation via pg_ctl (Kyotaro Horiguchi, Alexander Kuzm
 </para>
 
 <para>
-Previously this was only possible via an SQL function or a process signal.
+Previously, this was only possible via an SQL function or a process signal.
 </para>
 </listitem>
 
@@ -2697,7 +2697,7 @@ Properly honor WITH CHECK OPTION on views that reference postgres_fdw tables (Et
 
 <para>
 While CHECK OPTIONs on postgres_fdw tables are ignored (because the reference is foreign), views on such tables are considered local, so this release enforces CHECK
-OPTIONs on them.  Previously only INSERTs and UPDATEs with RETURNING clauses that returned CHECK OPTION values were validated.
+OPTIONs on them.  Previously, only INSERTs and UPDATEs with RETURNING clauses that returned CHECK OPTION values were validated.
 </para>
 </listitem>
 

--eMnpOGXCMazMAbfp
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="v2-0001-pg12-relnotes-v2.patch"

From 97ddf06bc9221153c52613b8c840409ee698bbad Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 14:15:57 -0500
Subject: [PATCH v2 1/2] pg12 relnotes v2

---
 doc/src/sgml/release-12.sgml | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index ab4d1b3..cc48960 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -127,7 +127,7 @@ Author: Peter Eisentraut <peter@eisentraut.org>
 -->
 
 <para>
-Cause recovery to recover to the latest timeline by default (Peter Eisentraut)
+Cause recovery to advance to the latest timeline by default (Peter Eisentraut)
 </para>
 
 <para>
@@ -205,7 +205,8 @@ Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
 -->
 
 <para>
-Require pg_restore to use "-f -" to output the dump contents to stdout (Euler Taveira)
+Require specification of "-f -" to cause pg_restore to write to stdout (Euler
+Taveira)
 </para>
 
 <para>
@@ -1003,7 +1004,7 @@ Allow logging of only a percentage of statements and transactions meeting log_mi
 </para>
 
 <para>
-The parameters log_statement_sample_rate and log_transaction_sample_rate control this.
+This is controlled by the new parameters log_statement_sample_rate and log_transaction_sample_rate.
 </para>
 </listitem>
 
@@ -1076,7 +1077,7 @@ Add tracking of global objects in system view pg_stat_database (Julien Rouhaud)
 </para>
 
 <para>
-The system view row's datoid is reported as zero.
+The system wide objects are shown with a datoid of zero.
 </para>
 </listitem>
 
@@ -1132,7 +1133,8 @@ Author: Peter Eisentraut <peter@eisentraut.org>
 -->
 
 <para>
-Allow viewers of pg_stat_ssl to only see their own rows (Peter Eisentraut)
+Restrict visibility of rows in pg_stat_ssl by unprivileged users (Peter
+Eisentraut)
 </para>
 </listitem>
 
@@ -1216,7 +1218,8 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
 -->
 
 <para>
-Allow more comparisons with information_schema text columns to use indexes (Tom Lane)
+Allow use of indexes for more comparisons with text columns of
+information_schema (Tom Lane)
 </para>
 </listitem>
 
@@ -1280,7 +1283,8 @@ Author: Magnus Hagander <magnus@hagander.net>
 -->
 
 <para>
-Allow the clientcert pg_hba.conf option to check the database user name matches the certificate common name (Julian Markwort, Marius Timmer)
+Allow the clientcert pg_hba.conf option to check that the database user name
+matches the certificate common name (Julian Markwort, Marius Timmer)
 </para>
 
 <para>
-- 
2.7.4


--eMnpOGXCMazMAbfp
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v2-0002-Add-commas-Previously.patch"

From f9d2ee1232090d9087f110d3299bdfae3ed2eab9 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 18:50:42 -0500
Subject: [PATCH v2 2/2] Add commas: "Previously,"

---
 doc/src/sgml/release-12.sgml | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index cc48960..3f9893e 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -115,7 +115,7 @@ Do not allow multiple different recovery_target* specifications (Peter Eisentrau
 </para>
 
 <para>
-Previously multiple different recovery_target* variables could be specified, and the last one specified was honored.  Now, only one can be specified, though the same one can
+Previously, multiple different recovery_target* variables could be specified, and the last one specified was honored.  Now, only one can be specified, though the same one can
 be specified multiple times and the last specification is honored.
 </para>
 </listitem>
@@ -183,7 +183,7 @@ Change XML functions like xpath() to never pretty-print their output (Tom Lane)
 </para>
 
 <para>
-Previously this happened in some rare cases.  ACCURATE?  HOW TO GET PRETTY PRINT OUTPUT?
+Previously, this happened in some rare cases.  ACCURATE?  HOW TO GET PRETTY PRINT OUTPUT?
 </para>
 </listitem>
 
@@ -384,7 +384,7 @@ Allow partitions bounds to be any expression (Kyotaro Horiguchi, Tom Lane, Amit
 </para>
 
 <para>
-Expressions are evaluated at table partitioned table creation time.  Previously only constants were allowed as partitions bounds.
+Expressions are evaluated at table partitioned table creation time.  Previously, only constants were allowed as partitions bounds.
 </para>
 </listitem>
 
@@ -515,7 +515,7 @@ Allow parallel query when in SERIALIZABLE ISOLATION MODE (Thomas Munro)
 </para>
 
 <para>
-Previously parallelism was disabled when in this mode.
+Previously, parallelism was disabled when in this mode.
 </para>
 </listitem>
 
@@ -793,7 +793,7 @@ Store statistics using the collation defined for each column (Tom Lane)
 </para>
 
 <para>
-Previously the default collation was used for all statistics storage.  This potentially gives better optimizer behavior for columns with non-default collations.
+Previously, the default collation was used for all statistics storage.  This potentially gives better optimizer behavior for columns with non-default collations.
 </para>
 </listitem>
 
@@ -1532,7 +1532,7 @@ Allow the streaming replication timeout to be set per connection (Tsunakawa Taka
 </para>
 
 <para>
-Previously this could only be set cluster-wide.
+Previously, this could only be set cluster-wide.
 </para>
 </listitem>
 
@@ -1825,7 +1825,7 @@ Use all column names when creating default foreign key constraint names (Peter E
 </para>
 
 <para>
-Previously only the first column name was used.
+Previously, only the first column name was used.
 </para>
 </listitem>
 
@@ -2329,7 +2329,7 @@ Allow control of log file rotation via pg_ctl (Kyotaro Horiguchi, Alexander Kuzm
 </para>
 
 <para>
-Previously this was only possible via an SQL function or a process signal.
+Previously, this was only possible via an SQL function or a process signal.
 </para>
 </listitem>
 
@@ -2697,7 +2697,7 @@ Properly honor WITH CHECK OPTION on views that reference postgres_fdw tables (Et
 
 <para>
 While CHECK OPTIONs on postgres_fdw tables are ignored (because the reference is foreign), views on such tables are considered local, so this release enforces CHECK
-OPTIONs on them.  Previously only INSERTs and UPDATEs with RETURNING clauses that returned CHECK OPTION values were validated.
+OPTIONs on them.  Previously, only INSERTs and UPDATEs with RETURNING clauses that returned CHECK OPTION values were validated.
 </para>
 </listitem>
 
-- 
2.7.4


--eMnpOGXCMazMAbfp--