Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQvTV-0001Tr-9d for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2019 15:05:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hQvTU-0005Ae-25 for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2019 15:05:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQvTT-00058o-IH for pgsql-hackers@lists.postgresql.org; Wed, 15 May 2019 15:05:43 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQvTL-0006s6-Tb for pgsql-hackers@postgresql.org; Wed, 15 May 2019 15:05:41 +0000 Received: by mail-qt1-x844.google.com with SMTP id d13so21279qth.5 for ; Wed, 15 May 2019 08:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=PYrEL9BpJuxCJTMktsxtOS4+V2NIYBMCchVZassGPkA=; b=eVWeVgwybhvW14hLOjNayynCzol8VXo8N21t8jwxaBjBRgR7ov2dz0TFUG39ePNvmd 6Cc7FmwDACiP/8GOdU4WRfks/PU566oW2P9ZVfvoEpCjB91vz7ceLNdZoHMLuiFhKcu9 3bth39wS4N5KVMLdY4eT+68pow1PVCsT8IFgcVHw5P3emyL85tJgKKasGJInSBC0Ym7d Q3+Ltke9eIukH/KWneNNCf6j8DHPLfjP83veovtIGm/vq/pg8ZpoZNmgG3/yXpEwQzt3 9Ky2/eOSexhDl9QGcVuq0XR1FTNNY8MzspLYnbMAOjZRURls6N86jCKbDCL/84PibuVU ytWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PYrEL9BpJuxCJTMktsxtOS4+V2NIYBMCchVZassGPkA=; b=enbovls9x0ByEvYIq16EyPX8ayh6yv7rDlqMnurHv9JUjkGPfEHuCKBjfM/MAy8Sbk JSoEKJ8paF2RxE6tB7VHK95nijX2fnzY2J4ogTifD95IUkuBgRqT+LX7YojPBK8/rob1 XMPBsfu69v6RWtZiNnH+i33z3gQLpsW1+hRNtqfdrXovoEgVBQU+zvUAfOdebzlpjpI6 3OkJ+n5hF3cf6CIi5XxisW2uBDNBCUw+zO/TcCCME6YelVBbkBFRzt5r/PpBXxRDHRtv MRYN6JohynhU1rroOSMa4EbFc5Pv0Hlod5vGtIZ3VLHE6PCLaipRhbVk9rbwWKHd2Az8 lCHQ== X-Gm-Message-State: APjAAAUKElOhaeo7QF+QvZK+HCxO9qet/92WJxdNxxZuuYEovrPLJ6Cg 2zrJbwHEJFVGmYCI2KNN7xQShg== X-Google-Smtp-Source: APXvYqxovdNLVHNtCKNEt/aO6kUXPuTzKfLkTANYElfnKrbWvwWBsYykL2+mFtS+vpf8Amnh4CitzA== X-Received: by 2002:aed:3512:: with SMTP id a18mr36568010qte.181.1557932735005; Wed, 15 May 2019 08:05:35 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id l40sm1830303qtc.32.2019.05.15.08.05.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 08:05:33 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 39DE9120A9D; Wed, 15 May 2019 11:05:31 -0400 (-04) Date: Wed, 15 May 2019 11:05:31 -0400 From: Alvaro Herrera To: David Fetter Cc: Tom Lane , Stephen Frost , Andres Freund , PostgreSQL Development Subject: Re: New EXPLAIN option: ALL Message-ID: <20190515150531.GA12534@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190513055112.GA24409@fetter.org> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-May-13, David Fetter wrote: > I tried changing it to EXEC (EXPLAIN EXECUTE is already a thing), but > got a giant flock of reduce-reduce conflicts along with a few > shift-reduce conflicts. After eyeballing the giant patch set you sent[1], I think EXEC is a horrible keyword to use -- IMO it should either be the complete word EXECUTE, or we should pick some other word. I realize that we do not want to have different sets of keywords when using the legacy syntax (no parens) vs. new-style (with parens), but maybe we should just not support the EXECUTE keyword in the legacy syntax; there's already a number of options we don't support in the legacy syntax (BUFFERS, TIMING), so this isn't much of a stretch. IOW if we want to change ANALYZE to EXECUTE, I propose we change it in the new-style syntax only and not the legacy one. So: EXPLAIN ANALYZE SELECT ... -- legacy syntax EXPLAIN (EXECUTE) SELECT ... -- new-style EXPLAIN (ANALYZE) SELECT ... -- we still support ANALYZE as an alias, for compatibility this should not cause a conflict with EXPLAIN EXECUTE, so these all should work: EXPLAIN ANALYZE EXECUTE ... EXPLAIN (EXECUTE) EXECUTE ... EXPLAIN (ANALYZE) EXECUTE ... [1] I think if you just leave out the GUC print from the changes, it becomes a reasonable patch series. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services