Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hQzRN-0005Em-OG
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2019 19:19:49 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hQzRM-0003gQ-B3
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2019 19:19:48 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hQzRL-0003ch-Ve
	for pgsql-hackers@lists.postgresql.org; Wed, 15 May 2019 19:19:48 +0000
Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hQzRJ-00047y-1Y
	for pgsql-hackers@lists.postgresql.org; Wed, 15 May 2019 19:19:46 +0000
Received: by mail-qk1-x743.google.com with SMTP id q197so731079qke.7
        for <pgsql-hackers@lists.postgresql.org>;
 Wed, 15 May 2019 12:19:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=S8kQ7LOWPk6lB0ebIg/5LbEXV7JQT1YRblHvpkB/1GA=;
        b=DXW20jJYkwQdT8ySX5SB4yuVJKLimu0JWtk8VOIBjbqg8o4tcofFxbRWLVH9rNRC5/
         6njf6ahbh8Y6vIVqwwU87zRkA/t54KTyaBxR1P3+MdWpM5GDOTH35qMMQe8sndAMEnlU
         pT29a0ypvc6eZEzH84U6atYSrTKLZ/4fpupjRTh9WCbpREuTCZeJk2sy3WqZskyK/sMa
         tekF9JE2rXPXmhBx8AFA2i1EF3gyGr4cMVA7mZfxkAEKXmY6df+gvw3uDdaXQ0QbnGdy
         ijbyHUWNvI6qAYL4T3QxqIlfaZgl89ru+0nCQsp0iJfDXjgXeZaAy3qQzWDizzj6REUM
         Y9RQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=S8kQ7LOWPk6lB0ebIg/5LbEXV7JQT1YRblHvpkB/1GA=;
        b=ryiUqsV44Z0cevmHVkP+zNe38j90oP78mBx1DqKm7nVp7A3HBM2aSo9PBfktH/yL9a
         rRxaeqHsg92B81XIre9kXFgtozA3xzj1Kyi54uKEDACltpDoxbIno5UQ4JbD+fZmQmbY
         jt50HRXS1RTThljCG9Namz8xhUbMDEhDvcEP83CCa0qYt3pan/BR7DMIiacZ/Q9bmoRW
         PYBKSjU20c6DUn3IEQW48ionIpVB/S5lopaz4AEcQhCgt/DuzLV4IGwLaNiHtmWebCkh
         d1BSNYGYTTIyQdn4CoLnX5KkTZIBKO6drG9+b0y1GGAIJ2kf6dx301Yj7Kcpo47k8GmH
         7bMA==
X-Gm-Message-State: APjAAAVITmsoGn8wPJ2BNk7XvVE/HqNLaU0egvpBmaiawvTNtSNA/veX
	zWXZRGF+7hAGj5JqKSIS7aAqRitaktNEoni5brA3c5tjmWSGlmxgB/Jvy+dLjg4pIHWPp/mOndy
	UEdxr+vsuGzuI527/9J/8iNWW/cxTbof/ccfLkY4d+ExJGcBY5alYM9RLx2ck7g8aytj3lIFN2u
	CuOH7IfDGtRUzfqQ==
X-Google-Smtp-Source: 
 APXvYqwQJP9KFdzUCYWMM2vWIwieyhvIulFaoaKNtL9Q3gLxTFPHyp7gpgRtA5CBFIt5CpqB0n5Xhw==
X-Received: by 2002:a37:884:: with SMTP id 126mr35877448qki.67.1557947983923;
        Wed, 15 May 2019 12:19:43 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 t55sm1896901qth.59.2019.05.15.12.19.42
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 15 May 2019 12:19:42 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id CB832120C07; Wed, 15 May 2019 15:19:40 -0400 (-04)
Date: Wed, 15 May 2019 15:19:40 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: ClonedConstraint typedef is dead code?
Message-ID: <20190515191940.GA6777@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18102.1557947143@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-May-15, Tom Lane wrote:

> catalog/pg_constraint.h defines a typedef ClonedConstraint,
> which AFAICS is no longer referenced anywhere.  Is there a
> reason not to remove it?

Oh, I didn't realize it had become completely unused!  It was used for
FK creation in partitioned tables, but we rewrote that code completely
and I don't foresee needing that struct for anything in the future, so
it seems safe to remove.

Thanks,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services