Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hV4qK-0003sb-Ur for pgsql-hackers@arkaria.postgresql.org; Mon, 27 May 2019 01:54:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hV4qJ-0008CN-AM for pgsql-hackers@arkaria.postgresql.org; Mon, 27 May 2019 01:54:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hV4qI-0008CG-V4 for pgsql-hackers@lists.postgresql.org; Mon, 27 May 2019 01:54:27 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hV4qG-0000rc-Gx for pgsql-hackers@lists.postgresql.org; Mon, 27 May 2019 01:54:25 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6745B22033; Sun, 26 May 2019 21:54:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 26 May 2019 21:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=iZ+DwFwSQzPui3WEWzwsrZSqUB1 XqdcXb3YOojJ418g=; b=sAb691T15VLyOYof4Ta1JXOpVApEj85Qpf37fYr5sL1 y3fqbjKU0smFOE7EKqaMNNAAHelo0aXsZ3pF7RPN86tOuJrkwxWiPjOUvw2+Mg/a E3OWQRmruX+Z4ebIVZASXAxedBMnPN4ta8r6CsXxde9+nVt/4zGLMbAnzgWjhxPD OucN5qzT82ogEge7A5tKcNHoVMPiBYEg720zPxJegRYQn/zvdcacDhRTC5IsVeWB ZscMa13RApwz1o2ToJUVTmiWRHwHeniRMnYq4/bITWpbu7aTgP+ccwWZxa4GKjPA sRLkoMYH7BDdWTcP+pDo3R62xTnK/7CvVix5o7bbUYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=iZ+DwF wSQzPui3WEWzwsrZSqUB1XqdcXb3YOojJ418g=; b=66mjSmF53W4/9yisTCgmFm suzWXD/GQLUT19qrpOXGHt0npAviAOPCR+vwWz4HirB0lsAzXME34GSNIq4zzskW zrxSWVwbrhAQRwK5rOU4zPqMWsdJeVZl3Z3Fe74mDPOOzrtama0DXKA5zP+aI+GI xbQK9GB+PFf3KsQozWFQNiq/zbvgPcwghFo9oA/EQ/er9s77MqPKMqomq2rf719c puhp5gFucdgxaUgaxrBIEMQdu0t1Fkn/bIHek2+bfwkT7ONeF9qjhte16lXXxDI5 wS6OqhDfzxnUCHLBWVYIZddwdyLMRp/Tk98WYUYV32gZg5IGWL/qA4+ubnQsJ2HA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddvuddggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedu X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id D0CD980062; Sun, 26 May 2019 21:54:21 -0400 (EDT) Date: Mon, 27 May 2019 10:54:18 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Tom Lane , pgsql-hackers@lists.postgresql.org Subject: Re: Inconsistent error message wording for REINDEX CONCURRENTLY Message-ID: <20190527015418.GD1963@paquier.xyz> References: <20190509041154.GC14573@paquier.xyz> <20190514153252.GA22168@alvherre.pgsql> <20190515021609.GD1440@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ryJZkp9/svQ58syV" Content-Disposition: inline In-Reply-To: <20190515021609.GD1440@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ryJZkp9/svQ58syV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 11:17:51AM +0900, Michael Paquier wrote: > Perhaps something like the attached for the REINDEX portion would make > the world a better place? What do you think? Alvaro, do you have extra thoughts about this patch improving the error message consistency for REINDEX CONCURRENTLY. I quite like the suggestions you made and this makes the error strings more project-like, so I would like to apply it. -- Michael --ryJZkp9/svQ58syV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlzrQ0oACgkQnvQgOdby QH10jxAAqoBFuFJE8q23mLjcQ9aRVYbSH61RCBjOHQqZlyQTE1U0LKXFbUSfAGcv sGxN8jo+3KJMDbXrRj4/9ZWT/2Qpd7zwR8MJMjVVufR7tnNc2AUgjPriqdTEgKGX V1pSswfeOzfJu6R8dyaKvPRmzQ5Fdg0goK0dV1oTnvKhMBB8DqFGKhbrNxvsHhXH vCjgXWGLCENJgPlKyxZDOM/T/FIOhrW3Nk1uO0u/U+h/OpWsYcbM60iXqEB6mC7l iBTop67KOz2tPOa8xkgcdFlf92aqy2rlhA2YefbhjgVHYPTxlD2liaHfrcwYdi8L XuXm5n65Bt4F6O4BLlhbEOgJAVweUzv4bCuyG64yDmSzH8lBW+9iH45VW91OKML0 iQQCNo+zNSScvR4gyVNDW+9tNIRyL1BSltNCaRsXs9w+0B06IKVx0MThF+sOmVAR UqTlW0/QUbhTBr+mx+5f/Uq84bNjdsOROJs0YsqZrdkV55fqkEMYKfCZNVv0U+rR EgEiQ+ja49JL1iDF3XrE5enQpJ5148rGyM1JtZrQ5ZydT/UmNcoAFLjOdtm9j5g/ VPmQMnaGTKuh82xyuxLGZgBly7iVnRafEvqRbM/DguHA7WB8Hdes7qk3llunh44l WcSJLOBaHWIiRVH/Tiy2Thizq9yn7iLCqsVjxssp4AIslCZytr8= =rupF -----END PGP SIGNATURE----- --ryJZkp9/svQ58syV--