public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: Amit Khandekar <[email protected]>
Cc: tushar <[email protected]>
Cc: Petr Jelinek <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Craig Ringer <[email protected]>
Cc: Petr Jelinek <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Minimal logical decoding on standbys
Date: Tue, 4 Jun 2019 15:57:54 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ3gD9dg0eQs5o1cJ_MSVVAy5EoiVsnez8nrZM0hWf6hYGHBww@mail.gmail.com>
References: <CAJ3gD9dKw8OEDjwbTmQ6e3-VGY64keNRxycHF4roJpsqhtssuw@mail.gmail.com>
	<[email protected]>
	<CAJ3gD9dv60f-QE21OQkZh3Wc1MCXrkVg=Yz5oPLzAmj-DQAeBw@mail.gmail.com>
	<CAJ3gD9fJdB6yZ5SL_h7GvVZxCLA7kXVpNzwjvggPge7kHZ1Bsw@mail.gmail.com>
	<CAJ3gD9d3uyK2iaO+PD=64HvOBerZPz3JyaPc6qF=kVZ_jGvgeQ@mail.gmail.com>
	<[email protected]>
	<CAJ3gD9f11mhBURoOTAEJXoFAUF74BzSz=XRjL01EBB3SkLdVHA@mail.gmail.com>
	<[email protected]>
	<CAJ3gD9czydP5VnYPTW_TSLK8p26TOzHx3hPTPT-hdkLVasFVVQ@mail.gmail.com>
	<CAJ3gD9dg0eQs5o1cJ_MSVVAy5EoiVsnez8nrZM0hWf6hYGHBww@mail.gmail.com>

Hi,

On 2019-05-31 17:31:34 +0530, Amit Khandekar wrote:
> On Fri, 31 May 2019 at 11:08, Amit Khandekar <[email protected]> wrote:
> >
> > On Thu, 30 May 2019 at 20:13, Andres Freund <[email protected]> wrote:
> > Yes, it waits until there is a commit record, or (just tried) until a
> > checkpoint command.

That's fine with me.


> Is XLOG_RUNNING_XACTS record essential for the logical decoding to
> build a consistent snapshot ?

Yes.


> Since the restart_lsn is now ReplayRecPtr, there is no
> XLOG_RUNNING_XACTS record, and so the snapshot state is not yet
> SNAPBUILD_CONSISTENT. And so
> DecodingContextFindStartpoint()=>DecodingContextReady() never returns
> true, and hence DecodingContextFindStartpoint() goes in an infinite
> loop, until it gets XLOG_RUNNING_XACTS.

These seem like conflicting statements? Infinite loops don't terminate
until a record is logged?

Greetings,

Andres Freund





view thread (196+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Minimal logical decoding on standbys
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox