Date: Thu, 06 Jun 2019 20:06:12 +0900 (Tokyo Standard Time)
Message-Id: <20190606.200612.110313249.horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: pg_checksums has an untranslatable string.
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
User-Agent: Mew version 6.5 on Emacs 22.2 / Mule 5.0
 =?iso-2022-jp?B?KBskQjpnGyhCKQ==?= / Meadow-3.01-dev (TSUBO-SUMIRE)
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Thu_Jun_06_20_06_13_2019_026)--"
Content-Transfer-Encoding: 7bit
Precedence: bulk

----Next_Part(Thu_Jun_06_20_06_13_2019_026)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hello.

# My email address has changed. Apologize in advance for possible
# duplicate of this mail because this is the seconf try after
# mail server seems to have failed the first try...

I found a string that ought to be translatable but actually not,
in pg_checksums.c.

>  fprintf(stderr, "%*s/%s MB (%d%%) computed",

It seems to be the only instance in the file.

regards.
-- 
Kyotaro Horiguchi
NTT Open Source Software Center

----Next_Part(Thu_Jun_06_20_06_13_2019_026)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="pg_checksums_fix_untranslatable_string.patch"

diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 1d75aa0282..7c7a75cdcd 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -146,7 +146,7 @@ progress_report(bool force)
 	snprintf(current_size_str, sizeof(current_size_str), INT64_FORMAT,
 			 current_size / (1024 * 1024));
 
-	fprintf(stderr, "%*s/%s MB (%d%%) computed",
+	fprintf(stderr, _("%*s/%s MB (%d%%) computed"),
 			(int) strlen(current_size_str), current_size_str, total_size_str,
 			percent);
 

----Next_Part(Thu_Jun_06_20_06_13_2019_026)----