Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hctCN-00068c-9B for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2019 15:05:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hctCK-0008RQ-7X for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2019 15:05:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hctCJ-0008PF-Tn for pgsql-hackers@lists.postgresql.org; Mon, 17 Jun 2019 15:05:27 +0000 Received: from tamriel.snowman.net ([96.255.250.162]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hctCH-0007Hm-Ch for pgsql-hackers@postgresql.org; Mon, 17 Jun 2019 15:05:27 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id AF8975F7AB; Mon, 17 Jun 2019 11:05:24 -0400 (EDT) Date: Mon, 17 Jun 2019 11:05:24 -0400 From: Stephen Frost To: Ian Barwick Cc: Magnus Hagander , Tom Lane , Amit Kapila , "pgsql-hackers@postgresql.org" Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions Message-ID: <20190617150524.GE2480@tamriel.snowman.net> References: <20190614160835.GF2480@tamriel.snowman.net> <20190616171610.GO2480@tamriel.snowman.net> <5218.1560705699@sss.pgh.pa.us> <20190616174332.GR2480@tamriel.snowman.net> <952db979-def2-11f4-0bab-780cf5fe688b@2ndquadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/WyilgS7+6IU2yVA" Content-Disposition: inline In-Reply-To: <952db979-def2-11f4-0bab-780cf5fe688b@2ndquadrant.com> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --/WyilgS7+6IU2yVA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Greetings, * Ian Barwick (ian.barwick@2ndquadrant.com) wrote: > However, going back to the original scenario (cascaded standby set up using > "pg_basebackup --write-recovery-conf") there would now be a warning emitted > the first time anyone executes ALTER SYSTEM (about duplicate "primary_conninfo" > entries) which would not have occured in Pg11 and earlier (and which will > no doubt cause consternation along the lines "how did my postgresql.auto.conf > get modified in an unexpected way? OMG? Bug? Was I hacked?"). No, I don't think we should end up in a situation where this happens. I agree that this implies making pg_basebackup more intelligent when it's dealing with that file but I simply don't have a lot of sympathy about that, it's not news to anyone who has been paying attention. Thanks, Stephen --/WyilgS7+6IU2yVA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJdB6w0AAoJEO1sijiDR2RVXqcQAJ8qPiu61CsUmdMirusLCkol jQgyAnmgGmxY6HaaMmTuc2qSlJQKzXovMvyzboxn/RsOk7i8ANCiUgXKzOiYXNCg iw6ThcHpEwCtsOAhxS0Z4bEDcag+mhvI1X6Yi8PryRtNlWgcdtjSmAixuAKmTnn9 ApcGNZKRmN7c5jqbyiOXqmE0+PurjSQgiZ56K35a1i8GSllh+jK9YJCuDi3W1ijF bSFK/7l9aYoMcjvpaYdDOL/R9NpBeQjPgcrbD/bE3k1H2DOlJQB9UofBgRdchxAo vAvlyELWsohhihuIlO/7jAiApWttt5LDEelmMZhiL9+bsf1PLANVTfr4+Yq2rEh7 OtkA3m5kluhwycohuTiVLfV/Zc2pilGIa1isanIn6oVCkpgHFqGhW4kf37PmZfBj F5jgkyB32nYo18dLY81Jopr7x1h1xIVwslBCcV3H2mrQQ5AOFRGMXJjkC7FWbZID ENs2zT4WbpJSCDjzjO0SxZQXugL7M+b+9L9B9Nl4jrkYErSyx7KTzLlMmYxLUXGZ rNZYzp1osvwzGu8duiQbijN15KU3YQEv90la6P/PcI8nmA1uhHpLo0gHlXl1FAEH cKHoGEMmyI9Lbjs4kxZIr8qsAt9TvJ3ZcupWR/OljuyXqtyVDfJhl9kUjBLrlK12 gtRKhuu70eSvcateM4Jg =iAML -----END PGP SIGNATURE----- --/WyilgS7+6IU2yVA--