Date: Mon, 24 Jun 2019 15:01:13 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Ian Barwick <ian.barwick@2ndquadrant.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Message-ID: <20190624190113.GX2480@tamriel.snowman.net>
References: <aed6cc9f-98f3-2693-ac81-52bb0052307e@2ndquadrant.com>
 <20190614160835.GF2480@tamriel.snowman.net>
 <CAA4eK1JW9UfLOtMEJq5b_YcogbWdxzAGUzNi72F2Xx4r1_h6QA@mail.gmail.com>
 <20190616171610.GO2480@tamriel.snowman.net>
 <27dc9f8d-8d8f-9dd1-0494-5d8bd2f49a45@2ndquadrant.com>
 <CA+TgmobVjrvVQB_gVytgBcPRmBvptN3wHQy5T6=dYCDZ5n5MGA@mail.gmail.com>
 <CAA4eK1+DrJyCm+borxpJSbyED0-zB=3ngVKsZqD3hu89G4HmYg@mail.gmail.com>
 <CAOuzzgqikaOFmR-08tP6Cj+WeAnpLJcO+xHoA36HncwHjg91DQ@mail.gmail.com>
 <CA+Tgmob6TH_Xu4BU_q9PU1=qFc=f=u2VvVfujJN-BWPfwV-DrQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9GYGtdBumnmR69ER"
Content-Disposition: inline
In-Reply-To: 
 <CA+Tgmob6TH_Xu4BU_q9PU1=qFc=f=u2VvVfujJN-BWPfwV-DrQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--9GYGtdBumnmR69ER
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Robert Haas (robertmhaas@gmail.com) wrote:
> On Sat, Jun 22, 2019 at 5:13 PM Stephen Frost <sfrost@snowman.net> wrote:
> > All that said, whatever code it is that we write for pg_basebackup to d=
o this properly should go into our client side library, so other tools can =
leverage that and avoid having to write it themselves.
>=20
> That is probably only going to help people who are writing in C (or
> maybe some close family member) and a lot of tools for managing
> PostgreSQL will be written in scripting languages.  It is unlikely
> that those people are going to get all of the rules for parsing a file
> full of GUC settings exactly right, because translating flex into
> Python is probably not anybody's idea of a fun time. So you'll end up
> with a bunch of rewrite-postgresql.auto.conf tools written in
> different languages at varying degrees of quality many of which will
> misfire in corner cases where the GUC names contain funny characters
> or the whitespace is off or there's unusual quoting involved.

Calling into C functions from Python certainly isn't new, nor is it
difficult to do from Perl, or various other languages, someone just
needs to write the bindings.  I'm not sure where the idea came from that
someone would translate flex into Python, that's certainly not what I
was suggesting at any point in this discussion.

> If you just decreed that it was OK to append to the file, you could
> avoid all that.

As I said elsewhere on this thread, I have absolutely no problem with
that as the documented approach to working with this file- but if that's
what we're going to have be the documented approach, then everything
should be using that approach...

Thanks,

Stephen

--9GYGtdBumnmR69ER
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJdER34AAoJEO1sijiDR2RVDXkP/3vbAtdbUJGpoLDii3iqcGrG
BWIC75fwIuLT1WTJOY+1BwbGszgjTQtwL4Ed9qv5Qvw/7R8hHWrlBY9WSMSf4yxT
Zk3EuOXF9NzKlS/n7C38x//TQofkqBA6sPL64nurgFLRhHEq0rxOEKkJNHVeZtv6
nA7KdHZFV7qyHhNG+R7Fy6fUMI3strItadu5PyJ140AFsw3v/1CsFOAFhI1StBrm
Wve69SUNxy2NFyFBhg21Z+ozdyuBCjDB60+tyfm9UfMyJOHKkG3GptPHreHWPhjx
Wz5dl9uNeEPOeaZCHr4AY9cdSb3NOuINQ0BiSV1olVsCBNPSdSGbkebBXiSWbtTo
3WIx1Sv8l1yHrv/K9K2OL7IsjZkC/Vwo+AggXiMyDdSp02No6Zqwbii1L3tPIfs3
Q/y2tKpGaX4MeCLSI2ieAkC7xwMFxr7dccTjtyWT9cjwzuAZpewNr3EYPBBNAzY9
lWSl0JxL1QJy/sRKkdbib2HpnAgb4tdktfxe79FzX6iIdrQRmPVG+7RQKPDR4hWz
sr7arAPW5ROM4oK+pTvy1xSVHAqtll62kksk6hq/6jDUbVGsOOLiJiNHi1DPZsO9
SHvkxgB6egBmZsKLjUA1GAFcGhsvLfftSqJSQ7dHxdsq94M/vlTscGBXf3GJHMwS
J0cjWIjHVwfGKCc2Cmx0
=GwuX
-----END PGP SIGNATURE-----

--9GYGtdBumnmR69ER--