Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzJe-00052h-05 for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2019 16:38:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hhzJc-0000Pr-Rn for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2019 16:38:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzHH-0001sn-Uy for pgsql-hackers@lists.postgresql.org; Mon, 01 Jul 2019 16:35:39 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzHE-00009L-Az for pgsql-hackers@postgresql.org; Mon, 01 Jul 2019 16:35:39 +0000 Received: by mail-qk1-x742.google.com with SMTP id t8so11517516qkt.1 for ; Mon, 01 Jul 2019 09:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=SZT1qUhVmSICHAtCnJ2ELQZee9gNvuppY6DkIb1u424=; b=ta11nqOWAjWHvAD7GPa88RQmXp7LSvqTOYIl/PcaGL3DCzdBRl8gRpoddaDSIqrJgr nz/PnsokGU+os978LNGT8Ow8+5GQQ6sMCbCbwNg7U4BFA6zXJG0cMP6n5+VicyiHx8z4 vbPjGWigvZgcdoIhFCiCBB1DGN34SUv416RM+uN+BhudlkYYdt/pfYiS5ZjjUi99cqMy 30H5GuBqoYTQ9y7psVKxHyvIIWCnYb02IYsqRsqmOfqcmhpbk43bTPibDMBR3V5RL2Qx CouaG1PLGB55FDTfAMse/DzkLHIsjXwPloy8QCypCbVNV0ZmXl0DyZ7R85vR34anvTBV Th4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=SZT1qUhVmSICHAtCnJ2ELQZee9gNvuppY6DkIb1u424=; b=notDOb0GDo1Fhf7bC/ue+QJ1/AhbVpMbSH6fuwuPTSArZFvmtxOf6t5ajmir2/or2k 2K1L4lsl/rjjo4Jw1M4gsvcHh9eVYyabe3v76LnuNbfF2xkH6ihde1l9c8PhX+ugDI0o LsVpY5/TEFtWwiKxxnXkzzD28LCTGOLc+kQ6g9haymhUpGtxrJo2YbvO8j85Rv5Yf8od jT9wYlbqiKt4zJ6wioBq0N+GGpMCI2T5HANQRkUqIU4uFzpblaL3ZUb1XPvJKKKozWt0 PnwnZOfDB5ImY8zKZa6ZOKukdO81/Ec4bgYx7D1S22zFuqT/+iucCQqiOMuVZpY4un6J WfsA== X-Gm-Message-State: APjAAAVoYI/SGzx39XjnO2ta/GRdGnaskJapd+erMnvG0iWDI0pDSjQb xj7icVAatGtc9HvR5C62hTP06Q== X-Google-Smtp-Source: APXvYqzur7kSD5McaK1MmqvnDKN+Bye/nxsqFzT/qoCl3ZDjugOMRkbNtT21mGN2tW3E496G+nGnNQ== X-Received: by 2002:a05:620a:1116:: with SMTP id o22mr21511176qkk.82.1561998934450; Mon, 01 Jul 2019 09:35:34 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id x2sm5103589qkc.92.2019.07.01.09.35.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 09:35:33 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id A6020120B51; Mon, 1 Jul 2019 11:57:01 -0400 (-04) Date: Mon, 1 Jul 2019 11:57:01 -0400 From: Alvaro Herrera To: Paul Guo Cc: Michael Paquier , pgsql-hackers@postgresql.org, Jimmy Yih , Ashwin Agrawal Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) Message-ID: <20190701155701.GA10900@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Apr-19, Paul Guo wrote: > The below patch runs single mode Postgres if needed to make sure the target > is cleanly shutdown. A new option is added (off by default). > v2-0001-Ensure-target-clean-shutdown-at-beginning-of-pg_r.patch Why do we need an option for this? Is there a reason not to do this unconditionally? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services