Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiNAg-00012n-91 for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 18:06:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiNAe-0006B6-2J for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 18:06:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiNAd-00063y-N9 for pgsql-hackers@lists.postgresql.org; Tue, 02 Jul 2019 18:06:23 +0000 Received: from xvm-110-146.dc2.ghst.net ([46.226.110.146] helo=fetter.org) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiNAa-0003W3-Pk for pgsql-hackers@postgresql.org; Tue, 02 Jul 2019 18:06:23 +0000 Received: by fetter.org (Postfix, from userid 1001) id A186C40968; Tue, 2 Jul 2019 20:06:18 +0200 (CEST) Date: Tue, 2 Jul 2019 20:06:18 +0200 From: David Fetter To: Peter Eisentraut Cc: Tom Lane , Stephen Frost , Andres Freund , PostgreSQL Development Subject: Re: New EXPLAIN option: ALL Message-ID: <20190702180617.GJ20338@fetter.org> References: <20190507212355.GQ28936@fetter.org> <20190507215449.3a4yb5kkoloq7yyw@alap3.anarazel.de> <4638.1557266803@sss.pgh.pa.us> <20190507221255.GO6197@tamriel.snowman.net> <5221.1557267912@sss.pgh.pa.us> <20190513055112.GA24409@fetter.org> <20190515060214.GZ28936@fetter.org> <30903.1557927151@sss.pgh.pa.us> <20190518183907.GE28936@fetter.org> <41059d7a-2223-aa00-b8f6-9093676b2b34@2ndquadrant.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41059d7a-2223-aa00-b8f6-9093676b2b34@2ndquadrant.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Jul 02, 2019 at 03:06:52PM +0100, Peter Eisentraut wrote: > On 2019-05-18 19:39, David Fetter wrote: > > On Wed, May 15, 2019 at 09:32:31AM -0400, Tom Lane wrote: > >> David Fetter writes: > >>> I hope the patch is a little easier to digest as now attached. > >> > >> To be blunt, I find 500K worth of changes in the regression test > >> outputs to be absolutely unacceptable, especially when said changes > >> are basically worthless from a diagnostic standpoint. There are at > >> least two reasons why this won't fly: > > > > Here's a patch set with a much smaller change. Will that fly? > > This appears to be the patch of record for this commit fest. > > I don't sense much enthusiasm for this change. Neither do I, so withdrawn. I do hope we can go with EXPLAIN and PROFILE, as opposed to EXPLAIN/EXPLAIN ANALYZE. Best, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate