Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiOuB-0005sN-0o for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 19:57:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiOtB-0002iE-Ks for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 19:56:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiOtB-0002i7-9B for pgsql-hackers@lists.postgresql.org; Tue, 02 Jul 2019 19:56:29 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiOt7-0004do-8O for pgsql-hackers@postgresql.org; Tue, 02 Jul 2019 19:56:28 +0000 Received: by mail-qt1-x841.google.com with SMTP id a15so19999770qtn.7 for ; Tue, 02 Jul 2019 12:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=iui4OfeM8p0FLWvKgjT0UFDGhBJXvvkEpSCtGjsO6gg=; b=Uu84CEKPQLJQCAtW9U2723RkY0e22Wb8oqpSim03rNnIIDR8XeLoCO2fzcp4dc4xOu 33pwOvQRMlQzyqZbFmM3Vj0rM8kOpvrdd/6xZQlM7W0LgZ0j/z6tYJx2ysUee2/XDCW0 7gpVsfM2YEgTnmyhvvc7wBAHaMWME8Ilf9HHt+Td1BrBuzEt3sdHqzhf3FM1aQmWEuBH uDUzRuT2SI0dlCAsImETxF+xhP5K/chpQshfu/a5My268RJlUuyv95UlQT0npEXDCYKC tXxJktNYNgU365TSl9hVjZObFJDLbRrYdJ5cRpNhVd0UPmUWiEyIDWx4h87pk4oKFxQB OoDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=iui4OfeM8p0FLWvKgjT0UFDGhBJXvvkEpSCtGjsO6gg=; b=MnoTcmhS1CDdWqOY2euTh5BBN9xo5v/MTv6dr0eVXfBv7OmhW+iWCwXpsZg/O1aLGL ZhIqonIePqA04AN7D8YAsYD9JBAAHVYA6LVgZujJ/llU3K3y8c4vwADl5d0FzuJCgdeJ pzr6AryXsX0P4cmw9L6jyfavPo7l8S82dm3cYn5y7ZLZQgUc0bGkhmJWIWuGcR6RFkw1 GBelFH/EyKM0suDNwt8k1hODwpvWqyrWNlAQ46TAqyJM7fwhP0Lw2uDah53h/qrAu7nB e9gyodP6VNDvMtmZARvHZJYwTaBpfdHgECL/xTdTp6DhxiDGamjgVcImieNh8lR0n3M/ NODA== X-Gm-Message-State: APjAAAUO0H/2h8b00GpJka0Z8c8xxT9PNurxC52sWJSNEzMQmqKXWrQa 79xuKZawqXaziHKXMUo8le4/ow== X-Google-Smtp-Source: APXvYqwSsOer19n+s+/yfljNBnyHpfUt/2JWGFeDZ+522J1DZ/yNB0Ak/FQVbddXZnciliViWztHqQ== X-Received: by 2002:ac8:5297:: with SMTP id s23mr27375089qtn.230.1562097382358; Tue, 02 Jul 2019 12:56:22 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id i16sm6205330qkk.1.2019.07.02.12.56.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 12:56:21 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 4611F1207B5; Tue, 2 Jul 2019 15:56:18 -0400 (-04) Date: Tue, 2 Jul 2019 15:56:18 -0400 From: Alvaro Herrera To: Tom Lane Cc: David Fetter , Fabien COELHO , Rafia Sabih , PostgreSQL Development Subject: Re: [PATCH v5] Show detailed table persistence in \dt+ Message-ID: <20190702195618.GA28184@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4561.1562094637@sss.pgh.pa.us> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jul-02, Tom Lane wrote: > * The persistence description values ought to be translatable, as > is the usual practice in describe.c. This is slightly painful > because it requires tweaking the translate_columns[] values in a > non-constant way, but it's not that bad. LGTM. I only fear that the cols_so_far thing is easy to break, and the breakage will be easy to miss. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services