Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hj6YZ-0002sr-QN for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jul 2019 18:34:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hj6YY-0007oR-1x for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jul 2019 18:34:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hj6YX-0007oD-MF for pgsql-hackers@lists.postgresql.org; Thu, 04 Jul 2019 18:34:05 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hj6YU-0003u8-Md for pgsql-hackers@postgresql.org; Thu, 04 Jul 2019 18:34:04 +0000 Received: by mail-qk1-x743.google.com with SMTP id r21so5889718qke.2 for ; Thu, 04 Jul 2019 11:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=xIi6uNt7QQsBcFOGMZ504Ap6Lgyn1AxdiO2Z9DiYTaY=; b=i/eFhn2OA57dYT7sAoHPSZNBE7ulbx4eFqWbE+zeKrDudVEqYUi9XVwJ85sgQ48n5G HwIhOmRZjZQSGaxkdd3yh5PIMtWay9XW7SKjDSfsf+tcGNqqITtW7q7F4fQ3mE3ka/wv /PYpEiuRA5fK9G2c8QT6w8DpiJM8lyfxNwRKlTH7OTTMaCNLu/kIPK17x7GOUKWTpO5i kz2WFlnMM8bFdObC40FSyfQt2METMYOtETc872Bj93e20CRwz8iOoAGc2ISBioK5T/Ew z8wBYVV3qsr42R75bSNAI/HXJbsPGqEeV9MkIsLBHO8KATCXRg3puKwvB+N7zAtOjcx+ zofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xIi6uNt7QQsBcFOGMZ504Ap6Lgyn1AxdiO2Z9DiYTaY=; b=ZBMdeCRlX57EzRcpUhe/CnBioRSmjBUUNSM0er41RnOEBlWZV8hu6TSda3VHKqZFY+ QTiT4uB0Wuz8MoeyYVTG2zk6/d8nkMrHx9cOJn2llw/FU5b49SVw9DIHZrkcyBvICj3V Pm4Erb+x/qAjHBNTuMnWntqTW/01vEmDYi0zcYP3gTBRg5uRTcccHgEmUtYUepJ6uvgB QjWBUt6gZBKfWIrD2iExR2zWNKwDIne5wFhVfMCjN2ZFLOjpsCNYcz4eMOJThIodCbp4 eSHx2qXpLNdcTE1hdDLHlKCeVNayqs4Jeiqm8wuLGN/2LQhRVMN4EOt19Va+4unjE9EQ C1NA== X-Gm-Message-State: APjAAAWuEnh0QK19qpBAtO7SnFdkltZtb73IXr8tRG/fwsZHHobgBKbt 5D38MsAvmA26BZP9UTJoUt3OaA== X-Google-Smtp-Source: APXvYqzofppN7M0pfnvtG9+ylTryJuFP7R/eCeVotXoQaqiyjYGmTJ1gQ3m9PxxaQzGR/eT4SpvCXw== X-Received: by 2002:a37:7646:: with SMTP id r67mr27352036qkc.249.1562265241574; Thu, 04 Jul 2019 11:34:01 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id r17sm2671906qtf.26.2019.07.04.11.34.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 11:34:01 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 9B0D0120282; Thu, 4 Jul 2019 14:33:58 -0400 (-04) Date: Thu, 4 Jul 2019 14:33:58 -0400 From: Alvaro Herrera To: Paul A Jungwirth Cc: David Fetter , Pgsql Hackers Subject: Re: range_agg Message-ID: <20190704183358.GA9138@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I noticed that this patch has a // comment about it segfaulting. Did you ever figure that out? Is the resulting code the one you intend as final? Did you make any inroads regarding Jeff Davis' suggestion about implementing "multiranges"? I wonder if that's going to end up being a Pandora's box. Stylistically, the code does not match pgindent's choices very closely. I can return a diff to a pgindented version of your v0002 for your perusal, if it would be useful for you to learn its style. (A committer would eventually run pgindent himself[1], but it's good to have submissions be at least close to the final form.) BTW, I suggest "git format-patch -vN" to prepare files for submission. [1] No female committers yet ... is this 2019? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services