Date: Mon, 8 Jul 2019 16:16:34 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Belyavsky <beldmit@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	Nikolay Shaplov <dhyan@nataraj.su>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Ltree syntax improvement
Message-ID: <20190708201634.GA17499@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CADqLbz+gUmusJYivWCqFt=LgEXsX5OUQBKZXQDDx4b3dtA23MQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Jul-08, Dmitry Belyavsky wrote:

> Dear Thomas,
> 
> Thank you for your proofreading!
> 
> Please find the updated patch attached. It also contains the missing
> escaping.

I think all these functions you're adding should have a short sentence
explaining what it does.

I'm not really convinced that we need this much testing.  It seems a bit
excessive.  Many of these very focused test SQL lines could be removed
with no loss of coverage, and many of the others could be grouped into
one.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services