Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkaK0-0007aR-37 for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 20:33:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkaJy-0004kx-Tt for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 20:33:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkaJy-0004j1-FE for pgsql-hackers@lists.postgresql.org; Mon, 08 Jul 2019 20:33:10 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkaJv-0004oj-5X for pgsql-hackers@lists.postgresql.org; Mon, 08 Jul 2019 20:33:09 +0000 Received: by mail-qt1-x841.google.com with SMTP id w17so16252327qto.10 for ; Mon, 08 Jul 2019 13:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=wTjT+/mFA+Oe0rZE0FrR/Dcn9bbd2fnxQQ3+rbVy27c=; b=dD+lrWF14EmbeBH7feHJLxctic5/pW/fNnnHxpsfuElV84HHkhBZtYcBVyETSkB+Q7 sKgLAIU3QiPwSc5p0N+ViQw8+H8fvAt7tw6g+YEJeuN292fq3PEni9j5+l6SV/SCb7pt ROr9ldmK9wgDGCXOWOoyweRcc2n9fopmXHVwA7cC9czSIZY8CWYsUTkTYxXdXfe5cjzY +O7tH5rBWaCmJhVUxbMposnAlW9ZxCrGREV0q0okWovLUPJpnCHUq0cSzTmsoo3+EQZ/ ASJScbmUkS2/cmP0Nvf8nti19zSmsxYJ3A82BftcCrCljUlOzMOWxfd1tDZWy6owdhhn +9eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wTjT+/mFA+Oe0rZE0FrR/Dcn9bbd2fnxQQ3+rbVy27c=; b=bFuqO7waJ3I/ApE6gtTCdFVI6xKWgORazCN3y9nmdXIk5ioi4J0yJg5C/LtaMl+DBq GOJQ7qoxZQEa/LIg93JGZAcLRaSgnG9BHMJ1PUBRkfWePH7VlnyP3TWAQ3SWqg6gfuLJ EIVES9x81lcCPNM3EII0yZcN/rRSfgjbpkpzjpl7qskikZsv1bL3kepNSkW2oQSWJeFD ZxMcIzJxMbcfa+NgJQHpfFrTxkyZL406CWLlqv1Q0C9EKpGzxFyWDg5p3OCouE3t0qtn TCyv5cmsHm5mj/JODZfQg4+n22MZMpiQkhywQWM9XErT1o3bdz1PZ7WWKkP/S3a7jfsf KXnw== X-Gm-Message-State: APjAAAWX8dX702DYo+bY1POXO/SYorfOnu604XdZZtAYESFzvvI9Sivi +kT2qpNrv+5x0wLTiWKYkKL99w== X-Google-Smtp-Source: APXvYqwUjXXZ8iunrCgY6dM8828c3t1w5LIQee+oTs0IAjIkexre5RTpmJshV4E7J4AaWSNI+n+5ZQ== X-Received: by 2002:a0c:d7cc:: with SMTP id g12mr15933182qvj.220.1562617985422; Mon, 08 Jul 2019 13:33:05 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id m10sm5445898qka.43.2019.07.08.13.33.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 13:33:05 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 568AC124A5B; Mon, 8 Jul 2019 16:33:03 -0400 (-04) Date: Mon, 8 Jul 2019 16:33:03 -0400 From: Alvaro Herrera To: Dmitry Belyavsky Cc: Thomas Munro , Nikolay Shaplov , PostgreSQL Hackers Subject: Re: Ltree syntax improvement Message-ID: <20190708203303.GA17993@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jul-08, Dmitry Belyavsky wrote: > I did not introduce any functions. I've just changed the parser. I mean the C-level functions -- count_parts_ors() and so on. > I'm not sure that it makes sense to remove any tests as most of them were > written to catch really happened bugs during the implementation. Well, I don't mean to decrease the coverage, only to condense a lot of little tests in a small powerful test. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services