Date: Wed, 10 Jul 2019 16:28:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Paul Guo <pguo@pivotal.io>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Jimmy Yih <jyih@pivotal.io>, Ashwin Agrawal <aagrawal@pivotal.io>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure
 clean shutdown)
Message-ID: <20190710072804.GC5042@paquier.xyz>
References: 
 <CAEET0ZEffUkXc48pg2iqARQgGRYDiiVxDu+yYek_bTwJF+q=Uw@mail.gmail.com>
 <20190319061851.GB2899@paquier.xyz>
 <CAEET0ZF0027KpHHXr1WKZubRs87d2t4ns6Vut+BB=e6+TsvHMw@mail.gmail.com>
 <20190320052007.GB26601@paquier.xyz>
 <CAEET0ZHPhBdx_s1OrMDuotzoM56x_mOB45CMw9ehxMFZRv4twA@mail.gmail.com>
 <CAEET0ZHRbn7ROSRCf-CV8Vp1QL+baTxd4=Ong1Dr7A0OuBzmyA@mail.gmail.com>
 <CA+hUKGJe-9nmXtnZ7LkALM5rdy1MdP5Z13fKoya=kFvSRG9jAw@mail.gmail.com>
 <CAEET0ZFJRibJP-c7TrFgJQnuTDOot-w2OWUBarcEuMpr5mQANQ@mail.gmail.com>
 <CA+hUKGLpm8FLVy3_-2k01_A6D=9OnNwdQegcDvJxKWoWdJj7sA@mail.gmail.com>
 <CAEET0ZFQ0s0K2YjaR3bMz-AyWrnz38VdYZtgA-h8Ss_LD6aSHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FsscpQKzF/jJk6ya"
Content-Disposition: inline
In-Reply-To: 
 <CAEET0ZFQ0s0K2YjaR3bMz-AyWrnz38VdYZtgA-h8Ss_LD6aSHA@mail.gmail.com>
Precedence: bulk


--FsscpQKzF/jJk6ya
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 09, 2019 at 10:48:49PM +0800, Paul Guo wrote:
> Yes, the patches changed Makefile so that pg_rewind and pg_basebackup could
> use some common code, but for Windows build, I'm not sure where are those
> window build files. Does anyone know about that? Thanks.

The VS scripts are located in src/tools/msvc/.  You will likely need
to tweak things like $frontend_extraincludes or variables in the same
area for this patch (please see Mkvcbuild.pm).
--
Michael

--FsscpQKzF/jJk6ya
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0lk4QACgkQnvQgOdby
QH3flQ//TaOw40cvPokL8nGTyAWi31O0PbIE5gR2JPRrGXgj6irEluGvBKE27RH+
egUH749+eEUYMMDNR3+tReK0R8MAkRlQUuV9AtDRBLMoMkbvpS7osZN0wNPJdOQU
7QStQqlxxkBMKBhGdKkmrn/9bCbeXD4CFuwwBKk7ToxVpekGAJ9v+d9feTMmCzVK
90cApoK4yX6S5+uBO2HwxF03f3Jqvq+0k1fByQ7R92cHNr5gB4PAMt2ucMI3Vmq+
m1BHV/Njxr3YAHBmTUBzd69yOpn2bU4S8ErwQaZ/pOZvTtRI/oWeo6BFymsIZ2TW
YhBXZTMvtHNtrcncZkYO2bHJ4vnPbgeCnhUkiLAi+UW9/yqRiqJLfJyR5MhyPCcv
BP2Z0Y566bxdptjPfCpGvtMramhPsQ3EIlyFs58MORBhDwewrJcoKfPazszX2bCO
Hl5L4zywIDTq6I9eEPB9RtE+P1zMGbjxQZiH+G9gaqyDWga/YtKhftw4vlaejEGe
vYLvfShxMvdkewNl+sERMIz9USOzMy+BhpmRDEG8wQBtIvsS+bfsOtNzNaUK68Mz
dmmB/2TSYU3UxZwIfg0bgZ9dvpyZIjbUMojbDDbqHdAniIgp57/KXiMVd28TT6Dv
+odXdGQUBbWL8+Hsvw1FUGKFDkZ79jNfnuSuMxRIIy0bTWnCQa0=
=4j1n
-----END PGP SIGNATURE-----

--FsscpQKzF/jJk6ya--