Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hla8T-00039E-6k for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 14:33:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hla8R-0004Vw-UP for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 14:33:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hla8R-0004Vp-Hy for pgsql-hackers@lists.postgresql.org; Thu, 11 Jul 2019 14:33:23 +0000 Received: from xvm-110-146.dc2.ghst.net ([46.226.110.146] helo=fetter.org) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hla8P-0000b7-63 for pgsql-hackers@postgresql.org; Thu, 11 Jul 2019 14:33:22 +0000 Received: by fetter.org (Postfix, from userid 1001) id 8579A409CD; Thu, 11 Jul 2019 16:33:18 +0200 (CEST) Date: Thu, 11 Jul 2019 16:33:18 +0200 From: David Fetter To: Dmitry Dolgov <9erthalion6@gmail.com> Cc: Thomas Munro , Pavel Stehule , Alvaro Herrera , Thomas Munro , Oleksandr Shulgin , Artur Zakirov , Tom Lane , Robert Haas , Andres Freund , Michael Paquier , Oleg Bartunov , Peter Eisentraut , David Steele , PostgreSQL-development Subject: Re: [HACKERS] [PATCH] Generic type subscripting Message-ID: <20190711143318.GL24679@fetter.org> References: <20190711074723.GK24679@fetter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, Jul 11, 2019 at 04:30:46PM +0200, Dmitry Dolgov wrote: > > On Thu, Jul 11, 2019 at 9:47 AM David Fetter wrote: > > > > Looks great! > > > > The tutorial piece has bit-rotted slightly. Please find attached a > > patch atop yours that fixes it. > > Indeed, I've missed this change, thank you! Although there supposed to be an > upperindex, not numupper (since the latter is just a number of upper indexes). Oops! Fooled by a suggestion from the compiler. My bad for not checking more carefully. Thanks for making this happen. Best, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate