Date: Fri, 12 Jul 2019 10:20:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	Daniel Verite <daniel@manitou-mail.org>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Kevin Grittner <kgrittn@gmail.com>
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
Message-ID: <20190712012007.GA2149@paquier.xyz>
References: 
 <CAOBaU_abD08HAxwnx3jGPuBV4POUMmvC_GdMn2qM_+PXsq6f+A@mail.gmail.com>
 <20190710141531.GA27615@alvherre.pgsql>
 <CAOBaU_Y3Pk-R6M6GSCGBeQtPH_V+h5-ueGaFV+rFOU0oHaGkNg@mail.gmail.com>
 <20190711040433.GG4500@paquier.xyz>
 <CAOBaU_bVFgyt17J4+BFXeAxJfHZQShixruEs_gdJ4A=XRvjxJQ@mail.gmail.com>
 <20190711133417.GK4500@paquier.xyz>
 <CAOBaU_YAtAApSHA-tfVA=sKu7WyU6_0w+vn+S_FE4H=9uxD+wQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6"
Content-Disposition: inline
In-Reply-To: 
 <CAOBaU_YAtAApSHA-tfVA=sKu7WyU6_0w+vn+S_FE4H=9uxD+wQ@mail.gmail.com>
Precedence: bulk


--IJpNTDwzlM2Ie8A6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 11, 2019 at 06:22:25PM +0200, Julien Rouhaud wrote:
> I think t hat it makes the code quite cleaner to have the selection
> outside ConsumeIdleSlot.

Actually, you have an issue with ConsumeIdleSlot() if there is only
one parallel slot, no?  In this case the current patch returns
immediately the slot available without waiting.  I think that we
should wait until the slot becomes free in that case as well, and
switch isFree to false.  If you want to keep things splitted, that's
fine by me, I would still use "Get" within the name for the routine,
and rename the other to get_idle_slot_internal() or
get_idle_slot_guts() to point out that it has an internal role.

> You're talking about getQuerySuccess right? That was actually the
> original comment of a function I renamed.  +1 to improve it, but this
> function is in common.c and doesn't deal with parallel slot at all, so
> I'll just drop the slang parts.

If we can design a clean interface with better comments, we can use
this occasion to browse the whole thing and make it better.
--
Michael

--IJpNTDwzlM2Ie8A6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0n4EcACgkQnvQgOdby
QH3nRg//ZfovlMSptHZzeiObEjg5BRu4jzG5A8N5eRMfQWePntXzBNSvNT6fKLLT
IW1tK0R3QSTuZ3z+pV3LEHNovwtdYd6YAo5qvZqTH8MGVhzQDCt0u1YfhVQJ1fcH
Yff3Cec/1C6ZH5rtbAdL4aHNGsXkyvVGhP4BBupNxBpe7QtNLd3JuWXPeEP+f9wC
jFhNxmtdX908VGHBGR1W7FHSab9VJo8pdgrllfPEFBesZfRgXUn6VZT6OO8M3QzP
3LL8FgEFAn/bXXg+fOnc3GK1HnmK/+kOZ80yp02xX/lwWwhat4SghkC6tuRU+RJV
9XU+U6OagZV54xOT5n+WWggRDLRK50sZOwGnwdsBjenWQh+BCNGkiWigtCTBVmR1
Y9c8ocFc2W8/juPAFIco2/K2E4veFBSWi5/JE+5T+0nNJST2PprNSFD/Whbn17Z7
b0PS2BrlwsIYb+5WMqHtcDVw1IhE6tV/raVQbY72McyNJXAoDTSp05/7N2JWfkeN
OeUb4+JKTqhN90ZFcW60qN/spx/rRvCvf4LFjead5Iuw8Q1L5+mBK1Rs4hAqwyBu
6AxVMJbHJlYSN4tH2mxxY14Ue8FrNJ3GbrAn82JM4AMaEnteSPSgftEh717aILi/
XLCImfdhFaQmPObudcDONHOXkZBbsllk+Dm4rMdnVzBt1jLqKQk=
=FmCN
-----END PGP SIGNATURE-----

--IJpNTDwzlM2Ie8A6--