Date: Mon, 05 Aug 2019 16:28:24 +0900 (Tokyo Standard Time)
Message-Id: <20190805.162824.123166397.horikyota.ntt@gmail.com>
To: legrand_legrand@hotmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <1564902241482-0.post@n3.nabble.com>
References: <20190801210514.qdiam2oazua6otkk@alap3.anarazel.de>
	<CAOBaU_aPixr3sj8Ov7o4eToOdA0f68ZV+Z4drn2LHn4QJTj8Tg@mail.gmail.com>
	<1564902241482-0.post@n3.nabble.com>
User-Agent: Mew version 6.5 on Emacs 22.2 / Mule 5.0
 =?iso-2022-jp?B?KBskQjpnGyhCKQ==?= / Meadow-3.01-dev (TSUBO-SUMIRE)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

At Sun, 4 Aug 2019 00:04:01 -0700 (MST), legrand legrand <legrand_legrand@hotmail.com> wrote in <1564902241482-0.post@n3.nabble.com>
> >  However having the nested queryid in 
> > pg_stat_activity would be convenient to track
> > what is a long stored functions currently doing.
> 
> +1
> 
> And  this could permit to get wait event sampling per queryid when
> pg_stat_statements.track = all

I'm strongly on this side emotionally, but also I'm on Tom and
Andres's side that exposing querid that way is not the right
thing.

Doing that means we don't need exact correspondence between
top-level query and queryId (in nested or multistatement queries)
in this patch.  pg_stat_statements will allow us to do the same
thing by having additional uint64[MaxBackends] array in
pgssSharedState, instead of expanding PgBackendStatus array in
core by the same size.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center