Date: Mon, 5 Aug 2019 13:29:35 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila16@gmail.com>,
	Ian Barwick <ian.barwick@2ndquadrant.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Message-ID: <20190805172935.GK29202@tamriel.snowman.net>
References: <15032.1561403529@sss.pgh.pa.us>
 <20190624192014.GB2480@tamriel.snowman.net>
 <56aff4f3-dec8-f462-7feb-0938411b04a6@2ndquadrant.com>
 <CAA4eK1+JMm=tvx720y6jhD8pdzt=HdS1-TwQwkARib2pwK8EvQ@mail.gmail.com>
 <20190802222254.qsvqjtkwte464lu3@development>
 <31697.1564784856@sss.pgh.pa.us>
 <CAOuzzgqNyQM_z0biEEBVBK9WcaLmbCyWrd5xTdf-Oxb_9pntLA@mail.gmail.com>
 <20190802230011.dqokdhjptykopxxc@development>
 <20190805142139.GW29202@tamriel.snowman.net>
 <CA+Tgmoatso2sR=_LSSR443YjAfvQ48zpbYYVYQUHVMSoxsrJ9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tgc5QVcMKz3Dypql"
Content-Disposition: inline
In-Reply-To: 
 <CA+Tgmoatso2sR=_LSSR443YjAfvQ48zpbYYVYQUHVMSoxsrJ9g@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--tgc5QVcMKz3Dypql
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Robert Haas (robertmhaas@gmail.com) wrote:
> On Mon, Aug 5, 2019 at 10:21 AM Stephen Frost <sfrost@snowman.net> wrote:
> > Just to be clear, I brought up this exact concern back in *November*:
> >
> > https://www.postgresql.org/message-id/20181127153405.GX3415%40tamriel.s=
nowman.net
> >
> > And now because this was pushed forward and the concerns that I raised
> > ignored, we're having to deal with this towards the end of the release
> > cycle instead of during normal development.
>=20
> I disagree.=20

It's unclear what you're disagreeing with here as the below response
doesn't seem to discuss the question about if these issues were brought
up and pointed out previously, nor about if I was the one who raised
them, nor about if we're towards the end of the release cycle.

> My analysis is that you're blocking a straightforward bug
> fix because we're not prepared to redesign the world to match your
> expectations. The actual point of controversy at the moment, as I
> understand it, is this: if the backend, while rewriting
> postgresql.auto.conf, discovers that it contains duplicates, should we
> (a) give a WARNING or (b) not?

No, that isn't the point of the controversy nor does it relate, at all,
to what you quoted above, so I don't think there's much value in
responding to the discussion about WARNING or not that you put together
below.

Thanks,

Stephen

--tgc5QVcMKz3Dypql
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJdSGd/AAoJEO1sijiDR2RVvFIP/ik0iUKX018Acyyt9SBs6DPc
nb0n6ISYKM0czQkxYvIeO9NQEwxz4SbYvhJlT8o2X/5g6CslE940iL3T6witvinX
dwvwzGmimlZrhApkHIx/lcdyLaaRd2dFdow0JF/wtccAxu3xNypQ0zW4EwnlrPlP
ZNj9v86mTJkH58ykvHQlBTPN2b4CCgAU5vHPC8IsAK/NJsS9uYn1vqIzosYqDF2s
BkPW2jazF0SesyzBYF/ZWXkIX2J+kE5Tn7atU+Fu00ElmtEhC5KRYPljYvhtZqTU
K67/WG+2gYMDUrEIfLrG3jo1oaBq/vQOp3tGc15tGT/FcdojZjkJvg3owa9UmUR5
9fxrtq8xI8qvq1OmXLCe05ZacuLgAAhwpyIRmENVH3UIjVNAVdeZ4jKrNxoa/OAj
+TSr6d5W46OoWjfBeGVNAOaVT5MnL+wD5sbPjQ1kd00ik43m9NHGtn0kQf72rE60
5dy/kHp1n175GnqHF3EhOgf33LoM0q7lIb4BU7MdyDvkn0V1aUAgGoMKiNvSsov4
wgccyJ02FR4SnSBSDaMUYFPMvCzLm5w3g1PPIFraz3Wuf891Hu+HatTGMWvMTr6L
t7unDkgWEm76ypYHjcixDeCYIH7RjIyTP3GvSMBwfTBzn3PXjoi3SbpNVjxlhAY0
ZqibAlJQ3Yw866D4SEQ2
=d9T5
-----END PGP SIGNATURE-----

--tgc5QVcMKz3Dypql--