Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hugsd-0003sb-Jc for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Aug 2019 17:34:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hugsc-0004B4-7r for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Aug 2019 17:34:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hugsb-00044Q-Pc for pgsql-hackers@lists.postgresql.org; Mon, 05 Aug 2019 17:34:41 +0000 Received: from tamriel.snowman.net ([96.255.250.162]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1hugsZ-0008S3-HH for pgsql-hackers@postgresql.org; Mon, 05 Aug 2019 17:34:40 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id C50E45F79F; Mon, 5 Aug 2019 13:34:39 -0400 (EDT) Date: Mon, 5 Aug 2019 13:34:39 -0400 From: Stephen Frost To: Andres Freund Cc: Tom Lane , Robert Haas , David Fetter , Ian Barwick , Tomas Vondra , Amit Kapila , "pgsql-hackers@postgresql.org" Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions Message-ID: <20190805173439.GL29202@tamriel.snowman.net> References: <20190803010802.rs3cz2kjq4dl4olu@alap3.anarazel.de> <20190803124111.2aaddumd7url5wmq@development> <16320.1564851579@sss.pgh.pa.us> <20190805162203.GR31493@fetter.org> <4768.1565022305@sss.pgh.pa.us> <5739.1565023404@sss.pgh.pa.us> <20190805165337.akba75vusf26irku@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BmkyeXk1FOw9T+vl" Content-Disposition: inline In-Reply-To: <20190805165337.akba75vusf26irku@alap3.anarazel.de> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --BmkyeXk1FOw9T+vl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Andres Freund (andres@anarazel.de) wrote: > On 2019-08-05 12:43:24 -0400, Tom Lane wrote: > > On the other hand, people have also opined that they want full error > > checking on the inserted values, and that seems out of reach with less > > than a full running system (mumble extensions mumble). >=20 > I think the error checking ought to be about as complete as the one we > do during a normal postmaster startup. Afaict that requires loading > shared_preload_library extensions, but does *not* require booting up far > enough to run GUC checks in a context with database access. I'm not following this thread of the discussion. You're not suggesting that pg_basebackup perform this error checking after it modifies the file, are you..? Where are you thinking this error checking would be happening? Thanks, Stephen --BmkyeXk1FOw9T+vl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJdSGivAAoJEO1sijiDR2RVK1QQAKOFjgJ+jmxr4921gBsR7yEH RrJ2fdYRuDuMgWR63ZvKbK+ZRdPE3RHOorz7a1qRylKObJ4dnzjbjHeEwc5OzFsw 1EVzdYZ3mZCxBcRytI5QBsB5cjwsyIiga06Pzrct99ibLnWqbZKVvw4RRs0yDhfc bNIY4Gf4BGuCtZ3KwPkOP7pD80zAH5FMj9dcg7QbybrBZKt0ZmNolS8nB+HV4OKt hEtdfuSx7lTjgraCmn846COpGk475xNao7go0Qq2knNOQjd9hGtJeKrsuLM3GdYf l89vn5W/FW3fQvSVEGRetmtiJ66XPQzQyL1Upt1Qz93sHvGP3afaKjezVheKctgr 8G5F3av1Iy0ArqrTww6Zg+fCeCM9WyFihtZ7zm7s4TEQenFF1FSiAvoze1h77sA5 GrjppNJinPTHzBe+W0iXPucbLiDZ+YAjGt6V//BapzkVJcJSEuXhxD5yXNIcCcDf LubjDNXfkqUe8oCDYjKnPDUBADjkgAtP2uah4KK2KUaVQgdfy2ngSmXw2IcNGmwS NYot2kqT/N5UKXf142J4Ardqoag89UcHeke9MsjXH1w5nlGfoeDsE2Ev30CarsWD o2ZMuJJDbVW6skwkwU2grfxm+KUFndMqyFWCOarX9FviUGmwZCN86uDa63XSduQQ hD1Wo9uL3X3GvReFkC2V =Dned -----END PGP SIGNATURE----- --BmkyeXk1FOw9T+vl--