Date: Sun, 18 Aug 2019 20:18:40 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: =?iso-8859-1?Q?J=FCrgen?= Purtz <juergen@purtz.de>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: doc: Add some images
Message-ID: <20190819001840.GA8390@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3a73caef-6892-14e7-d5e5-11ac19ab381a@purtz.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Jürgen,

On 2019-Aug-18, Jürgen Purtz wrote:

> it is be possible that you face the following situation: the image
> subdirectory contains all ditaa and graphviz source files, but not all
> corresponding svg files. Those svg files are created by the given Makefile
> of this subdirectory resp. should be included in git (and patches - what was
> not the case in one of my patches).

Not really ... I did create the .svg file by invoking the make rule for
it manually.

The files do exist, but they are in the wrong directory: they're in
/pgsql/source/master/doc/src/sgml/images
and the "make postgres-A4.pdf" was invoked in
/pgsql/build/master/doc/src/sgml/images
       ^^^^^

As I said, if I edit the .fo file to change the "images/foobar.svg"
entry to read "/pgsql/source/master/doc/src/sgml/images/foobar.svg" then
the built docco correctly includes the image.

A "VPATH" build is one where I invoke "configure" from a different
directory.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services