Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hziYC-000498-Og
	for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Aug 2019 14:22:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hziYB-0001wf-CP
	for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Aug 2019 14:22:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hziYA-0001uf-To
	for pgsql-hackers@lists.postgresql.org; Mon, 19 Aug 2019 14:22:23 +0000
Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hziY6-0007iz-Uv
	for pgsql-hackers@postgresql.org; Mon, 19 Aug 2019 14:22:21 +0000
Received: by mail-qk1-x743.google.com with SMTP id g17so1524049qkk.8
        for <pgsql-hackers@postgresql.org>;
 Mon, 19 Aug 2019 07:22:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=YmdJrwXt9Y0Jv/1yl3DHgOiisqQqrvgRcgwr1sZibd8=;
        b=rgBB1xCGnpYBEKkZI7VqhqRQsZRshkjT/BHxsD638aXx8nwKZHHc1uShx5Mya+KATL
         6rsQlFqeaeY9Pjwtd2dr9PPIu++j+6TVNQUODEswya0njxoP/50YiPr+BSzih95p1sng
         HAOpxAFOOPPlaZDzbWFphMSAGXdFNAdxMohQ3tNbQhnQhNCLqQtrrBAyE5ekelkMv1Az
         4LdK4Jpyy7K8oJlBx8jqZWJnBHzHm0xDwfJoA0aEntzyrtKM0EeuotST2e4jFjTqv+sa
         ZJ8nDBKjpSypz+L9jOMTfRdo4UOxhhb5R0vQcwTuNipUEc2PC8sgoh4iWzlP3WPXlE+y
         lP/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=YmdJrwXt9Y0Jv/1yl3DHgOiisqQqrvgRcgwr1sZibd8=;
        b=th3b8Hq5woOsvOEUoXkxk6It9E25B/qFOXmr24/cQNOTC43630Y9s0xWM4cs9wuTJd
         ZzaXd6s0ec2r7OQ//Um4kNyQTKi68ed9bohdJzTI2Pqk4O/bgPqcKoJV0MtXAzdt8tq5
         1yVpiAAI7SOmj9V5dVCklejAnLaU7obD62wu4k2/n25R/1KyQBPt1ZHuIe1w92s6HA0b
         LJbk02xFjOkk3Ku+KAm4pZEh0mwG0ZmlpSFhnr0C22A4FMIywVNR60T7prtJZHpRdi0D
         uNMh/Y4KBtjaE9ZMOepkV7dfxwYb/7HJlwTsadsXDQ5KZthCyQP2g9McXLiwHFcicMNU
         DZpA==
X-Gm-Message-State: APjAAAU16TzRVLgvl5kBj3CaWR5qgrHtxT+IfHpYWk2zbAO5M92HK4ph
	FG7o5d6/VHsqvZ1deayB5/oNhw==
X-Google-Smtp-Source: 
 APXvYqzbAKdo2lSJ9e2dr16rn6sD/FR5FLXPSjj9Afh2eRittyoxjI7blyMw9CZNgFIa0/miM6mFPA==
X-Received: by 2002:a37:4cd5:: with SMTP id
 z204mr20434551qka.67.1566224537427;
        Mon, 19 Aug 2019 07:22:17 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 w10sm7092095qts.37.2019.08.19.07.22.16
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 19 Aug 2019 07:22:16 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id F2CD21239EA; Mon, 19 Aug 2019 10:22:14 -0400 (-04)
Date: Mon, 19 Aug 2019 10:22:14 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
Message-ID: <20190819142214.GA9703@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <14803.1566175851@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Aug-18, Tom Lane wrote:

> I wrote:
> > (My headerscheck script is missing that header; I need to update it to
> > match the latest version of cpluspluscheck.)
> 
> I did that, and ended up with the attached.  I'm rather tempted to stick
> this into src/tools/ alongside cpluspluscheck, because it seems to find
> rather different trouble spots than cpluspluscheck does.  Thoughts?

Yeah, let's include this.  I've written its equivalent a couple of times
already.  (My strategy is just to compile the .h file directly though,
which creates a .gch file, rather than writing a temp .c file.)


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services