Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hzp9f-0001Ry-QH for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Aug 2019 21:25:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hzp8e-0007ok-PX for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Aug 2019 21:24:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hzp8e-0007jA-Ah for pgsql-hackers@lists.postgresql.org; Mon, 19 Aug 2019 21:24:28 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hzp8a-0003Xe-IE for pgsql-hackers@postgresql.org; Mon, 19 Aug 2019 21:24:27 +0000 Received: by mail-qk1-x744.google.com with SMTP id m10so2749884qkk.1 for ; Mon, 19 Aug 2019 14:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Dgtt5X8HvTB9j+ZfmoaxZ0MUGFUQ0oV35jrjS+L65Lo=; b=W0v6Hzcgmq06tBDHd6sYK3MvrCQgrtyq5sj8OF2GPp2i8ZYLPmWhwQJeLuOR5YVyWC WWWGSlZ0Zi8sHcqFjjo4gjozGm+IAox2oqwlo2iyUprGMt7rFhBhqz+deZlkKcShfq5x z7ZXhc0vK5K+KTImp/ARc+m33kOpLLGR3X19UE2/a1R5Tt/JSPflHhK06VeK20v/MsOK bWxhkqSE6kd16sjORZq1iJ+XZpPnUCQQ47u380ds4gnQBBQsJxDGMGgQTaoRYrUhs8Ze WQbn+vR2Dd3Ty6FQ0ou+uMwMVSvh9aSLXuQFhijgjRchSih2kDsxLeq27PIfg1zt5wYs ykOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Dgtt5X8HvTB9j+ZfmoaxZ0MUGFUQ0oV35jrjS+L65Lo=; b=qiVR0biqw321Q95ozKqH74fH2akWoO+a3NzGx1fZQZV3y5WwLwFIjhCzvYJV6zWqFc +oyQ0RVvD7qdNFMGqq/4SQmuLfcSDqiEDgi8Zvo+fDIaZz/CtI0z7VxSnlzBY/r21Jr2 5+YnSDwFl7aqSTyw3c4VbobuZJsWRSIgE65qonfNcqU4sVWNp7qJ9J/JrFb84rEw2pN+ Tgv5azXBW0vxk2Lur+9VkIyN5ZpiDFSDIMVI8boj3frhjGSz8ZkJMoVX4bVL/HI+bz5R 8DOM5aA4V+tabNlD5/1MymINOXewrrn1i6MAn23dCk82mhr9tRsGHq86gA7BvcD0F5em ZnoA== X-Gm-Message-State: APjAAAW+OGLn1emyIBc0xgflt0GIoYQWMoOa2tnBAfDUlmvdJwpcMDYl ldaKAdkip38kDuWakrM89yUl/A== X-Google-Smtp-Source: APXvYqxCn/jC1Uf0tLLohS4cZze6dNBkQdBYhuYa0zrgacM8K8AzBn78ibc/4JpoUmBA8ChCdHcAwA== X-Received: by 2002:a05:620a:13c5:: with SMTP id g5mr3459375qkl.433.1566249504105; Mon, 19 Aug 2019 14:18:24 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id t9sm1130096qkt.135.2019.08.19.14.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 14:18:23 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id B20121239E5; Mon, 19 Aug 2019 17:18:19 -0400 (-04) Date: Mon, 19 Aug 2019 17:18:19 -0400 From: Alvaro Herrera To: Andres Freund Cc: Tom Lane , vignesh C , Pg Hackers Subject: Re: Unused header file inclusion Message-ID: <20190819211819.GA4374@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190819204626.6h4mkpgljtfk43zh@alap3.anarazel.de> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Aug-19, Andres Freund wrote: > > I wish we could move the whole logic of those scripts into makefiles, so > > we could employ parallelism. > > Hm. Perhaps the way to do that would be to use gcc's -include to include > postgres.h, and use -Wc++-compat to detect c++ issues, rather than using > g++. Without tempfiles it ought to be a lot easier to just do all of the > relevant work in make, without a separate shell script. I used to have this: https://postgr.es/m/1293469595-sup-1462@alvh.no-ip.org Not sure how much this helps, since it's a shell line in make, so not very paralellizable. And you still have to build the exclusions somehow. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services