Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0eVk-0007YS-1e for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Aug 2019 04:15:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i0eVi-0006Eo-80 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Aug 2019 04:15:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0eVh-0006AC-N1 for pgsql-hackers@lists.postgresql.org; Thu, 22 Aug 2019 04:15:41 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0eVc-0002Nw-Tn for pgsql-hackers@postgresql.org; Thu, 22 Aug 2019 04:15:40 +0000 Received: by mail-pg1-x541.google.com with SMTP id k3so2681398pgb.10 for ; Wed, 21 Aug 2019 21:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HUjm+Dr9NT15Ou7klZ2vX76VTxry4ynB1qXX/4wqBkk=; b=QxEqVl/+bDmivJa2bW7e4S8U9fWpfh8MS3xlQ49SLJSu0yjkVoGacQZrSDgBb6LNAG 5c7/Mc+YDNfdk1I73u75TZjQUU6Cvso+SBr8sn6Jh6uFDaxjaB7+9PVD1XiHcGope70T JkL6IAcA9723UYrNBIytGGpO9CYQyuBoaZRYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HUjm+Dr9NT15Ou7klZ2vX76VTxry4ynB1qXX/4wqBkk=; b=sdHGLu7eK2ZIl1ZqEaEYsiW5X5PSrpmpVp7rLmF+pNuIbeGlKzpvxTcY5Y6XYlV2fa ffno+rW5/DlPt66tE9XReEWduax8ZrwO8kuldTJ4d8iRuHvftmuH7WXVwMhrgdaNEd4y lnsZdQPfk4HDnsEv1fClC8srHgbFu6UfHXUJzHGP+Ul2tGK5LaI+YFy4gdV36PSUlzuT X4J1LVZ9TiqzfFsJ/nlZIGEEMPraiXofAScigiLEEoPkee6GYyIZaUnvTL2c7t4imzG/ 5rbklzsx5h6HVOJ0SlaOXnJMWjZ8b2NNgR2/5R1NGC08YlJyfUJ/kR2nqrG6uMaTxfqv AMJA== X-Gm-Message-State: APjAAAUs5tH3qhc7y0iJUUEljWOpRnJp6brSFwdrTg7TsAlXzoOMkPwH k0YiV7BPl4V7gl0LbF2Gaht7Bw== X-Google-Smtp-Source: APXvYqzdHgYHcJg7K5eDhAXzsAL0XD5vDhezjzl6Dsot6E6EUJRtNJTBXYIuLRd9wOkmpFstHUD6cQ== X-Received: by 2002:a17:90b:14c:: with SMTP id em12mr3257659pjb.22.1566446892649; Wed, 21 Aug 2019 21:08:12 -0700 (PDT) Received: from rfd.leadboat.com (108-233-125-46.lightspeed.sntcca.sbcglobal.net. [108.233.125.46]) by smtp.gmail.com with ESMTPSA id z16sm23319009pgi.8.2019.08.21.21.08.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Aug 2019 21:08:11 -0700 (PDT) Date: Wed, 21 Aug 2019 21:08:09 -0700 From: Noah Misch To: Kyotaro Horiguchi Cc: pgsql-hackers@postgresql.org, 9erthalion6@gmail.com, andrew.dunstan@2ndquadrant.com, hlinnaka@iki.fi, robertmhaas@gmail.com, michael@paquier.xyz Subject: Re: [HACKERS] WAL logging problem in 9.4.3? Message-ID: <20190822040809.GA3117472@rfd.leadboat.com> References: <20190818035230.GB3021338@rfd.leadboat.com> <20190819.185959.118543656.horikyota.ntt@gmail.com> <20190821.163238.176512239.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821.163238.176512239.horikyota.ntt@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Aug 21, 2019 at 04:32:38PM +0900, Kyotaro Horiguchi wrote: > At Mon, 19 Aug 2019 18:59:59 +0900 (Tokyo Standard Time), Kyotaro Horiguchi wrote in <20190819.185959.118543656.horikyota.ntt@gmail.com> > > At Sat, 17 Aug 2019 20:52:30 -0700, Noah Misch wrote in <20190818035230.GB3021338@rfd.leadboat.com> > > > For two-phase commit, PrepareTransaction() needs to execute pending syncs. > > Now TwoPhaseFileHeader has two new members for pending syncs. It > is useless on wal-replay, but that is needed for commit-prepared. Syncs need to happen in PrepareTransaction(), not in commit-prepared. I wrote about that in https://postgr.es/m/20190820060314.GA3086296@rfd.leadboat.com