Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5BnN-0007eX-FG for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 16:36:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i5BnM-00037d-6l for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 16:36:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5BnL-00037W-Up for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2019 16:36:39 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5BnJ-0007wS-9o for pgsql-hackers@postgresql.org; Tue, 03 Sep 2019 16:36:39 +0000 Received: by mail-qt1-x842.google.com with SMTP id y26so20727201qto.4 for ; Tue, 03 Sep 2019 09:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=XUlXfLi/sSaS+aR2s2/cqwgDsiQGBARpbSAXFS6D4QI=; b=1Xj4Sj97BHc27k/YyhkCII2UTI/BV+UGC5jYvxgcLm3Ui7mwSWEwhqcoQznNGCVjMh GCs7TetHSlxw3XyTR1h9Qr+j1U7TbL7yIN4kg0EwVSDEh5tItsD5UWyB1J6cuUv4QJiq It8yrxhGkvcAsXZLYnAE3kgRpRFSfWQQy1OMF/qiaUCl9adLJPN5IblQxCHeq35+X3GF TkuGzT0v9nKGJ/NlEJlv+Pns6mLWX4wTyYiRW0aCrpam7cJJ3Yn6Er3faTVeM6+ouNWn 7CK+JPpAZACAEOJtvpwLnlwXgOxD8runRQtlvr2LxQASSRbYnHyfrk9qypMJ5JHQPhqd vkEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XUlXfLi/sSaS+aR2s2/cqwgDsiQGBARpbSAXFS6D4QI=; b=mZDGLhxvyrtnru6++aFDuDr3r+1xwcuihkMO+F37549fUksf8plU3VxXWPQfsSZuhe dHGFFFQ51TSqHf1yZFEpxKysOgCsyqjiEbw+1CqPU+zqlP12eJEpfmVX286qUCmhVsND Cch0nBOkUwAAHl52DCbIPUYizeFY7k2bUswU0MPND+dZ6wNs46KyZKDb1TjtTLmHdHxx RKPNYI4VCYAC3uUmWH3X4Ar2YMXEM+cpBKxvnbIrn44yRij0OyrHDzCUnYsuxJ/TwY60 F/AesKRocFyK3egN1RLRCfxpSZVeKHQG150QjpSLXH3toUUKeXjZUWx5aoHgSDye5405 xORw== X-Gm-Message-State: APjAAAX7mTa5WLEtqf9evkId8i8caJ0qOR6j6u7nBm/0jqF02YjWf65V UOWEXTmunl4X0LxzVrhQClXHoA== X-Google-Smtp-Source: APXvYqxNYUfbHe74Dz0ZoPc5QslFpqiv5KSwkKQXqnPG0QG6LVFKk0Rc8hRGYKZgPcahEaET8xuYXw== X-Received: by 2002:ac8:845:: with SMTP id x5mr22011892qth.42.1567528595836; Tue, 03 Sep 2019 09:36:35 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id d2sm8433932qko.26.2019.09.03.09.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 09:36:35 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 89935120BB0; Tue, 3 Sep 2019 12:36:33 -0400 (-04) Date: Tue, 3 Sep 2019 12:36:33 -0400 From: Alvaro Herrera To: Tomas Vondra Cc: Melanie Plageman , Hubert Zhang , hackers , Thomas Munro Subject: Re: accounting for memory used for BufFile during hash joins Message-ID: <20190903163633.GA16230@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190711154011.lmkp7jyd3e2zfcnx@development> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jul-11, Tomas Vondra wrote: > On Wed, Jul 10, 2019 at 04:51:02PM -0700, Melanie Plageman wrote: > > I think implementing support for parallel hashjoin or explicitly > > disabling it would be the bare minimum for this patch, which is why I > > made 2 its own item. I've marked it as returned to author for this > > reason. > > OK. I'm a bit confused / unsure what exactly our solution to the various > hashjoin issues is. I have not been paying attention to all the various > threads, but I thought we kinda pivoted to the BNL approach, no? I'm not > against pushing this patch (the slicing one) forward and then maybe add > BNL on top. So what's a good way forward for this patch? Stalling forever like a glacier is not an option; it'll probably end up melting. There's a lot of discussion on this thread which I haven't read, and it's not immediately clear to me whether this patch should just be thrown away in favor of something completely different, or it can be considered a first step in a long road. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services