Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5CUF-0001Fo-OG for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 17:20:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i5CUE-0000rC-Kg for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 17:20:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5CUE-0000r5-C9 for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2019 17:20:58 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5CUB-0008O5-Cc for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2019 17:20:57 +0000 Received: by mail-qt1-x842.google.com with SMTP id a13so20900606qtj.1 for ; Tue, 03 Sep 2019 10:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=K7JPD8MZqwo25jEtZYxnS6OkOBdnaf2J6wYm640yE9E=; b=W+bo7GWm+V5LBxNcAsXEkE+9PweqbSGXs4jh6k4WNjuo5ssu2L4GJfEjaodLD/l3Sd VXr1nhXkHeO9It42EuUk/YRAUWKsh6w09BGUz38d2aREnh7PGHiuCfXVNtYJvpFYIM5C MKCjVSeKWCEgDjg5k/4jzJ9l9B2kRtROPumLaVsJiWaMgNkxRoCm4+3vo5Oam1Uz9otB YhJzImHR6Gt1Jj+Z3g/FvoJzl2aLSekMNyMLny76hQJ4O0h8MyvgmlmiMZ4eGHtY+ZkE rZt3PZ3+azn68Me18js5eVLgOw5BZIPxMP3iCYaECLoXehSaNFG32I2q60SuIET2olua RYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=K7JPD8MZqwo25jEtZYxnS6OkOBdnaf2J6wYm640yE9E=; b=Faohog99D13W+waX1/tPnbAD6aFDZuO2dO8DAKoQxxZJ1aD0TRtvPpJ7nlsZLCAH+L aKYRebLog5HxPlddOzI2/eCrguV3mLyxzAFRe2JSNPKiDsVfaAx82ipo2dcf2Pi80w25 Ekd5/DRmZSReyDHcst1+Y8J1zxqfaAvhZ2zsJjrCkVZgbJSGQx9J7CFj+lt+d/W4iqik YIu8m+ssgPVchkpi01Hf+EACx/NG7tP/9q9Dyc2UC3jsqU+QonKZYG0WD4GNyUmpw/oW bcSosADOFWNL0kYiHRRlSZ0mFPqkqv6g3P2Nrjbshiawmq+RLHDo0KHuSYK/cnbRm+H9 FK7g== X-Gm-Message-State: APjAAAUawSV1dYCeFRa6JvaIdq35EL+Wr3yQwLMe6vYNeArqEUjgvsJt D400RSbg5+Y+G48bO2T7VC3jFvTxAVOGqg== X-Google-Smtp-Source: APXvYqxSONz3rTwNee0fwjAY02y5AnI08RfbgcPF5TjDRPanuqI+UJvIBK3cvWrzwzCFRq/40fH1sA== X-Received: by 2002:ac8:802:: with SMTP id u2mr27249091qth.160.1567529777383; Tue, 03 Sep 2019 09:56:17 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id c8sm4462314qtp.11.2019.09.03.09.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 09:56:17 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 24B9E120BB0; Tue, 3 Sep 2019 12:56:15 -0400 (-04) Date: Tue, 3 Sep 2019 12:56:15 -0400 From: Alvaro Herrera To: Shawn Wang Cc: pgsql-hackers@lists.postgresql.org, Antonin Houska , Ants Aasma Subject: Re: WIP: Data at rest encryption Message-ID: <20190903165615.GA16727@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <156472805641.1401.3119816532289012709.pgcf@coridan.postgresql.org> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Aug-02, Shawn Wang wrote: > Hi Antonin, > It is very glad to see the new patch. I used the public patches a long time ago. > I did some tests like the stream replication, much data running, temporary files encryption. > I found that there is an issue in the src/backend/storage/file/encryption.c. You should put block_size = EVP_CIPHER_CTX_block_size(ctx); under the #ifdef USE_ASSERT_CHECKING. > There is some problem to merge your patches to the latest kernel in the pg_ctl.c. Is a new, fixed version going to be posted soon? It's been a while. Also, apologies if this has been asked before, but: how does this patch relate to the stuff being discussed in https://postgr.es/m/031401d3f41d$5c70ed90$1552c8b0$@lab.ntt.co.jp ? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services