Date: Tue, 3 Sep 2019 14:52:01 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: remove "msg" parameter from convert_tuples_by_name
Message-ID: <20190903185201.GA14872@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+HiwqE8_Z01+9bWkWjEK-ZozwMx4AOJo34-yu2W4_RGm2u6CA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Aug-07, Amit Langote wrote:

> If we're reducing the message string to occur only once in the source
> code, can we maybe write it to be more informative?  I wonder if users
> aren't normally supposed to see this message?

Grepping for the messages given to convert_tuples_by_position yields
quite a few matches in regression test output, but none for the one in
convert_tuples_by_name.  This makes me think that it isn't user-visible,
unless things go very wrong.

Pushed the patch, thanks.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services