Date: Tue, 3 Sep 2019 18:28:05 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com, tomas.vondra@2ndquadrant.com,
	andres@anarazel.de, a.zakirov@postgrespro.ru, ah@cybertec.at,
	magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us,
	pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Message-ID: <20190903222805.GA13932@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190711.164059.130487447.horikyota.ntt@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Jul-11, Kyotaro Horiguchi wrote:

> Hello. This is v21 of the patch.
> 
> > CF-bot warned that it doesn't work on Windows. I'm experiencing
> > an very painful time to wait for tortoise git is walking slowly
> > as its name suggests. It would be fixed in the next version.
> 
> Found a bug in initialization. StatsShememInit() was placed at a
> wrong place and stats code on child processes accessed
> uninitialized pointer. It is a leftover from the previous shape
> where dsm was activated on postmaster.

This doesn't apply anymore.  Can you please rebase?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services