Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1i5HSP-0005rS-M0
	for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 22:39:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1i5HSO-0002QB-Gg
	for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2019 22:39:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1i5HSO-0002Ml-74
	for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2019 22:39:24 +0000
Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1i5HSH-0004A3-FG
	for pgsql-hackers@postgresql.org; Tue, 03 Sep 2019 22:39:23 +0000
Received: by mail-qt1-x843.google.com with SMTP id b2so18595914qtq.5
        for <pgsql-hackers@postgresql.org>;
 Tue, 03 Sep 2019 15:39:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=BInYl4fnINru7Ki4A4QVKzvruC0LoWBNtGFkg39goAs=;
        b=Ix47lNltXoqSV+MpZnp1Tw4akFn4gLy4esyb/V1eh5pjNfdsNWKrnp+3f/KdDKEr5U
         n/PIRF4BJqD8rC4RzG94v7oO81yuh0zD6Mnp4xrtpQoFtR1yo5MxVQPj/p2eEt3WT1+E
         e4fnuD+gALfu6FgQEktL6hqlyIwEu8jqliXfgjC7b1zn+gd+34rm2E+u63lZnfNatn8n
         drkHtjFjTA3Br/6jGNFrQUSEwmv8vsXKyJJXqyu7ocnmQY0yzfTCGUozs+xGNOGNpeGe
         tc0+FGV47qFpax8LuZKz+s2c8GmoC4kuh+2JfwJZSivzEL2FV8gzhG7L4Z7ZTH62D4n0
         N1wQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=BInYl4fnINru7Ki4A4QVKzvruC0LoWBNtGFkg39goAs=;
        b=cqAxSDZn0ayHZFGs0UeUU/qa1cWVXIxrc5QIWfhBNtJhQklNiT6D9zZERwoLguPa4v
         UHteMx7VpdWN3RPgClrI2w4AZAtMY1rZOWYL80daW2f1IwcxcJKStWVBdKpjRwvnZJWM
         jCiKpVxLjCguW9ABOc6i916pepbDdR3pZCM1GwHbFXpSU6Nm2vqm7MrMVT2nYU8nZDva
         pAv2PDeXen1Pf7Uhcp03P3YGnM5dRoxKi6ePd1i7Zdb5x6myglQIyu4qpm6/f6xKJIxS
         PmGDrSu8S1DBFTlgXXeas/kKkqPDHI0PJIEfQUTDS2IAVvSuVX+y4dLw/161KZ5aznW4
         PxbQ==
X-Gm-Message-State: APjAAAVwpruoA3fliLUzE5eyMSbrds8Q8n3kdeKdTPi8mj5ZqqpgWa3d
	aCpVmNQ9WgzVBNqbl5Pz6mCATA==
X-Google-Smtp-Source: 
 APXvYqwFVF/gYYqiA8O+1rwAKtAnWcbJDm7u5useYvaEB23yDxxtdPIGuIHVn7UaoaxWD+r5kjhm6w==
X-Received: by 2002:aed:2f42:: with SMTP id l60mr4751615qtd.315.1567550355825;
        Tue, 03 Sep 2019 15:39:15 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 62sm1870016qki.130.2019.09.03.15.39.15
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 03 Sep 2019 15:39:15 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id E783B1239EE; Tue,  3 Sep 2019 18:39:13 -0400 (-04)
Date: Tue, 3 Sep 2019 18:39:13 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Paul Guo <pguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Jimmy Yih <jyih@pivotal.io>, Ashwin Agrawal <aagrawal@pivotal.io>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure
 clean shutdown)
Message-ID: <20190903223913.GA14603@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAEET0ZF+Pjm7t9vafnpSvh+g_Jeun7UNs4rHrUxV2d9bFPzttQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Jul-15, Paul Guo wrote:

> Thanks. Both Mkvcbuild.pm and pg_rewind/Makefile are modified to make
> Windows build pass in a
> local environment (Hopefully this passes the CI testing), also now
> pg_rewind/Makefile does not
> create soft link for backup_common.h anymore. Instead -I is used to specify
> the header directory.

It seems there's minor breakage in the build,  per CFbot.  Can you
please rebase this?

Thanks

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services