Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5gmT-0005Yi-BV for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2019 01:41:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i5gmR-00059F-D4 for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2019 01:41:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5gmR-000598-1U for pgsql-hackers@lists.postgresql.org; Thu, 05 Sep 2019 01:41:47 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1i5gmK-0006TW-Dx for pgsql-hackers@postgresql.org; Thu, 05 Sep 2019 01:41:45 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 59EE8445; Wed, 4 Sep 2019 21:41:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 04 Sep 2019 21:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=EB2RkQyWDj4p1tKyeBByqf8bL0Z wMs4ITFvyCG6UPG0=; b=mwBL8uu0c1GddfjWB5HQ7uoTOIt2HU2SuwV0bebgb53 UqL/Ngls8M9xizBoz8goiNhtZx2/iLynUOYR2MMOGhCeF/XQfnp2/nChMpBV/jKE x8b1C0L1V0ZbqwOVY+dhhhs8195gCx6YGSVG7JVyxlLGr2mzlBcabM4XfeIaZPHg xqTU8lMzddP20xexneK6CRwpiuB9JT6QPd2m5Qum/YAN9lNzRd8oup1VRF6KnpOI nlnWCls38gT8IzhvN+6y5F/Im2UXTfsLvRA5Mbyzm8nj1LMP6lYzeKm9YoToKQB2 QI+xF0sEqaWQRqyZgFbIBaV/tBuCttcmhOAmIan5XWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=EB2RkQ yWDj4p1tKyeBByqf8bL0ZwMs4ITFvyCG6UPG0=; b=o+UJ1nyolDZIQLdA1pVRfE ZsttyjFlGjtL2CG3Nd1TeBOejon2DYK2ioBtP8Wb7K14fTCHJMObPOqCcBuhb7cQ i6F6PQa4fQASI4CPbzEd71p8SWhg0b/NEEp78kPpDHtGoTpNOprBKeBcwPMdcHLc yRK8Yh7FI+IqkJcbLEanL8ydMefKjYiyFl0MTLQz1r0XBqx30aDeN75OlIqfgwRk 3jHYo2a+lEVkh0S7LiYi2Sf9jukTif1+fhC196ulmitZcTlVEUipmv2ZFMBxcplS s8gOoYqbGzugJDaqXCu/dowvgg16O6HBM1lv5p4ZxwW41ZeHLDUa0EbUB0mngGIA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejiedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 5BCEA8005A; Wed, 4 Sep 2019 21:41:34 -0400 (EDT) Date: Thu, 5 Sep 2019 10:41:31 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Masahiko Sawada , Craig Ringer , Ashutosh Sharma , Julien Rouhaud , Peter Geoghegan , PostgreSQL Hackers , Abhijit Menon-Sen , Peter Eisentraut , Pavan Deolasee Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks Message-ID: <20190905014131.GD14853@paquier.xyz> References: <20190904194629.GA12433@alvherre.pgsql> <20190904205045.GA14613@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hxkXGo8AKqTJ+9QI" Content-Disposition: inline In-Reply-To: <20190904205045.GA14613@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --hxkXGo8AKqTJ+9QI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 04, 2019 at 04:50:45PM -0400, Alvaro Herrera wrote: > According to CFbot, the Windows build fails with this patch. Please > fix. To save a couple of clicks: "C:\projects\postgresql\pageinspect.vcxproj" (default target) (56) -> (Link target) -> heapfuncs.obj : error LNK2001: unresolved external symbol pg_popcount32 [C:\projects\postgresql\pageinspect.vcxproj] .\Release\pageinspect\pageinspect.dll : fatal error LNK1120: 1 unresolved externals [C:\projects\postgresql\pageinspect.vcxproj] I think that it would be more simple to just use pg_popcount(). That's what other contrib modules do (for example ltree or intarray). -- Michael --hxkXGo8AKqTJ+9QI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl1wZ8sACgkQnvQgOdby QH1hLA/9E4mjA34LclMwyvACYQz79/PJw0OfzwM1T4DWtFeNZXHCXn/wDNgNL/Sg eYpYeAa4sSnwNITKDJYr1JujEmmMagpmAa74O8vjqrcYiT2xRcIGxiA0HiQUbEDQ BR071eBIQan50ZG3yez1BCczC9e67Erg9BlS3XAiOjdEgkKdAfO03LPJB/yqvqlU 5tjz8wYCMJVnPeahn8yeRU9eYsmM85RWOjUnttc7RM78jg4Ws9X23h5l6mK6Rp+y 1xoXtU08Y1dNyWnl1nl9W+E4Z/8u7BcssW+7TywAINaGwjefANAflMC4FnKn40Vo NbSFRartbvOnPgs5A5iRyMxAnJVMUs1tjLNeS2THQUj6NnfJsdMT6cqryJzHwB1k /vj8q/kVbjMFWDkwCZm6Z/U2pK3LfJ9tXuAOLNLR4Cbln81/O7TQwKDEk1SMruk9 R0AAIbq+CmS738jM56XEdkOTZp2NgdhUAksf5NADscXs1dfQYQDUM8wndkfk4ry9 ZeiKEEnzkKYxlXGMzcvXjIC1Cu3lt73vFq4FvjBgfBOkywpTFZo9+zPtO5KipIF8 ordasjqizL3WQVDoWRcPmvIExLu3sGu654luTG6b0KtpRESGzKRprGPIKHzf/7hy gcHg8fFqXabaZXjSYhLoO2hmT3NlvbcTiw0S82P2BrtQyJroiu0= =1AXq -----END PGP SIGNATURE----- --hxkXGo8AKqTJ+9QI--