Date: Mon, 9 Sep 2019 08:35:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Message-ID: <20190908233559.GA2467@paquier.xyz>
References: <6628.1567958876@sss.pgh.pa.us>
 <5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
 <17551.1567979940@sss.pgh.pa.us>
 <688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com>
 <18363.1567981113@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5"
Content-Disposition: inline
In-Reply-To: <18363.1567981113@sss.pgh.pa.us>
Precedence: bulk


--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Sep 08, 2019 at 06:18:33PM -0400, Tom Lane wrote:
> Sure, I saw that you can run one test that way ... but what do you
> do when you want the equivalent of check-world?

I think that it is a good idea to add in subdircheck an extra path to
check after TAP tests and run optionally these on top of the normal
regression tests.  I have a couple of comments.

+   # Look for TAP tests.
+   if ($config->{tap_tests} && -d "t")
+   {
+       print
"============================================================\n";
+       print "Running $module TAP tests\n";
+       my $status = tap_check(getcwd());
+       $mstat ||= $status;
+   }
Shouldn't we check after TAP_TESTS in the Makefile?

There is an argument to also check after isolation tests and run
them.  It seems to me that we should check after ISOLATION, and run
optionally the tests if there is anything present.  So we need
something like fetchTests() and fetchRegressOpts() but for isolation
tests.

The glob() part is a good idea in itself I think.  Why not
back-patching it?  I could double-check it as well.
--
Michael

--FL5UXtIhxfXey3p5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl11kF8ACgkQnvQgOdby
QH2HsRAAiRRWKFfVEbkYSG8LAiOJSgDBCuu98BZc6AfpKwRDjL78EkrxrBnafNCW
IUW5PDDJ++g8Q65/Lt4qrCJyhwVODdDubuqj+BzI0EdJot5tonpsmkwDIaaOATAd
xWOfIqlYx+fqjMBqK80pIvOjgtgElJsnBrZF8rLxoIsTjqOH2Byx1p68QSjPVC07
k+BeMDV8rWV4nGg1MXzPzoewX1H6/wYCpbeHvyBCgPd1xQmBnBVqMxl3eaaVMX8i
cgI/4sdmqL7T4CDSXRTrW0FMg7MiZA+XW4PyoBwBKHHjrfMaLpb71ctmX3AHcTB1
egXyU7onJMNmhWmauLxvZLcw2LtpfBskNnZlUw0n68UzMf6ap735M7d/KZXzCPiG
4X0D0jbBX2WLMH4ZTKwO2JwC59XLFet2mIXcs32LhTAKVl576qtdZbwOSJR4RfV1
2wSb6TOEhS5m9vedRdQb/5VL3UPTGuLAzS0a+pHQi+rxUamu0XIRx3dIZ/pItB7o
39EW9j/mMD+YjC2hN+WmsNKCTvrFTcPBxTcYPUKNJ6AYYnqKxA68JleFHINinpgY
BlZaAGWcxKj69KsMzPJpDODn8VSYGN1cnh3ZUbxIBlu8i9gx9uDTSxlBzJq17O98
vn20b72A2cfo4LzQaM4Vq0UVhJixy80Cxl4iPlcEZDKNKts/XkI=
=ZJoV
-----END PGP SIGNATURE-----

--FL5UXtIhxfXey3p5--