Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i9rjr-0000Hn-UX for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Sep 2019 14:12:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i9rjq-0001pm-GT for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Sep 2019 14:12:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i9rjq-0001pJ-2z for pgsql-hackers@lists.postgresql.org; Mon, 16 Sep 2019 14:12:22 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i9rjm-0000Qv-Jn for pgsql-hackers@postgresql.org; Mon, 16 Sep 2019 14:12:21 +0000 Received: by mail-qt1-x842.google.com with SMTP id g16so9890937qto.9 for ; Mon, 16 Sep 2019 07:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=oePYg53z+tPp2SEHHk4sAz/O0MIxdLoJ8896B9D+oKs=; b=aIfC4dbU5L31LZBCK5pA9IVAw1+J2+vCKHOY7tbU50NuTfh6pOa8bVXHsx7e/4Rax8 42skD/9DWRJvBu1Ru6aTDhb/WtHC+9nBKG31FwuKaojaYspryasOzX1GL/0iVUc02T5B Qxu0kOWxrPuec5yD+hin/1rrefiqSC/M+dLCnuooVzVr7fZilLeOBfmCYTQmhzPZ/gfe dVY/9UOTqrSCt8qm2K6c3wsbAYrbqwNJJQxJHEeLTTMrSRJts4BT2X80Cf1I4fvAMzAJ CnvD5AHAkw9Jkwsz2BK8/5Tagmb9tDvv8nr1CVYmJ2vl0kVmbA9aYyWKwMww44n3ii6F ufTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oePYg53z+tPp2SEHHk4sAz/O0MIxdLoJ8896B9D+oKs=; b=NV24GGfH0OrCS1+xv6g2SvLfQnnVeZ4nrGbnXk4xjw+pSVFDQ9kk1WaH9p5gQk8OQa I5L8Z87hsM19Z7XfBZCq8ezi0NgJ7f+FyRBLvE2cT5nfROOGuKbNnzcIfyf5BtokfdPq pE+EDNeaUSup0MZImtM38X6YlapTvvBt85AI8tQFnwzk1jG/y98qbLTRMWsnXPpPjQNS YpuJ5ZlSIs1BomJxmO8qCv8B4L5X2vN3Ykw4ZNWpHRRUeA5/iDoUdpAWecYnfvHLas9m 9bCliTZdafuC+60Lzik29xTyDzUrW4/0bkpRQk8RSaRMbAJ3WD4+iUvIJdCYKCv8fEYH EqYg== X-Gm-Message-State: APjAAAV1N19FKO4hVPmdBEICl/6IZE2+tmlyQEncOi9vVNpPLSGMtkl5 MHqoWX+mvMeUKHMA10Hz7HfRXA== X-Google-Smtp-Source: APXvYqwgzDVHWcEvPulInt1gy1eJzI7svCMtp3pXGAKvmX7mfqwiCG97svEczTtIjHyL/316eFcnLg== X-Received: by 2002:ac8:47c3:: with SMTP id d3mr14974126qtr.4.1568643136842; Mon, 16 Sep 2019 07:12:16 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id v2sm15863148qtv.22.2019.09.16.07.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 07:12:16 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 083FA1205E5; Mon, 16 Sep 2019 11:12:15 -0300 (-03) Date: Mon, 16 Sep 2019 11:12:15 -0300 From: Alvaro Herrera To: Tattsu Yama Cc: Michael Paquier , Tatsuro Yamada , robertmhaas@gmail.com, Rafia Sabih , Dmitry Dolgov <9erthalion6@gmail.com>, Peter Geoghegan , pgsql-hackers@postgresql.org, Jeff Janes , Thomas Munro , Michael Paquier Subject: Re: [HACKERS] CLUSTER command progress monitor Message-ID: <20190916141214.GA10855@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Sep-16, Tattsu Yama wrote: > I should have explained the API changes more. I added cmdtype as a given > parameter for all functions (See below). > Therefore, I suppose that my patch is similar to the following fix as you > mentioned on -hackers. Is this fix strictly necessary for pg12, or is this something that we can leave for pg13? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services