Date: Tue, 17 Sep 2019 13:06:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Craig Ringer <craig@2ndquadrant.com>,
	Ashutosh Sharma <ashu.coek88@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Abhijit Menon-Sen <ams@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Message-ID: <20190917040618.GD1660@paquier.xyz>
References: <20190916134056.GB6026@paquier.xyz>
 <20190916141106.GA10690@alvherre.pgsql>
 <20190917004417.GA1660@paquier.xyz>
 <CAA4eK1LQsGOLkvpcK8_SQs6yVGriv_yuwQPh69=3c5C_Vd8MgQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="//IivP0gvsAy3Can"
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1LQsGOLkvpcK8_SQs6yVGriv_yuwQPh69=3c5C_Vd8MgQ@mail.gmail.com>
Precedence: bulk


--//IivP0gvsAy3Can
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 17, 2019 at 09:23:45AM +0530, Amit Kapila wrote:
> We always return a single tuple/record from this function, so do we
> really need to return SETOF record or just returning record is
> sufficient?

Right (with the doc update).

> If you want to use the same size array, then you might want to just
> memset the previous array rather than first freeing it and then again
> allocating it.  This is not a big point, so any which way is fine.

Sure.  This is less expensive though, so changed it the way you
are suggesting on my local branch.
--
Michael

--//IivP0gvsAy3Can
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2AW7oACgkQnvQgOdby
QH1o6RAAn9lmxPXZZRU1BKjxtYKK8oT+2AAZTbbOpiL03ZzsKOVUA9yQG7FKuhwl
Z5V3TeOowAaXSplR1PM+cv43/3hH1gIywcL29Z7dc/45IIrNheMf3SXePbBi+6et
2HVGc1wdrYjn5gpjVE7j7oOBqA+3Wb+1aSqViX79NysxuKKftu2MMxywlvzB5+Eh
wC9edehmghLVEaGdVx0wTx4fKnErQcGBvLMLxFVp263cbIBS5WUr9O7tCK+GAZCH
KQmLeYn/FCq0ADDUChOpizqZMMGA6qg817IpARVnJRMMT41+aqASIGUbCMakLTSf
yprZq+TRxH6D5poqYW8gnBE/26tczzsV3r/VIEs45MRg3BeAwockComBMYb3n8pL
8GUviNvU04Id4usgE00Sl5aFpA4tZZ3socku3a1aT4XBNkjJFQISqmzVhqsxvnA7
dzuOAvHGslyY+M0MF7d3amIaPCJojSDm2eD8PEqkdIzf/kCeC9N7zii2W2qNc0oK
Cjui5kD3ITtMk8ggQb2qF+FgdrQ1QUXPlTibGVbV57dWzRXE99pdQFqH+rE77aNq
AlBr3D+vxYZ53Lf8rDymTiJZVsjjpqxXkOhwkzA+s5ADfBTahgYP8N0mQmMedRJ0
i92tPc+P92hbdE46pQq7nbdgs8NBIjlxqfdZmd0yR5FIJTAqKzI=
=70fJ
-----END PGP SIGNATURE-----

--//IivP0gvsAy3Can--