Date: Wed, 18 Sep 2019 09:58:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: subscriptionCheck failures on nightjar
Message-ID: <20190918005815.GB8909@paquier.xyz>
References: <31663.1550082243@sss.pgh.pa.us>
 <20190213183303.ns54frt7cmvo6pgg@alap3.anarazel.de>
 <1466.1550085086@sss.pgh.pa.us>
 <CAEepm=0wB7vgztC5sg2nmJ-H3bnrBT5GQfhUzP+Ffq-WT3g8VA@mail.gmail.com>
 <20190213215147.cjbymfojf6xndr4t@alap3.anarazel.de>
 <20190813080435.GL2551@paquier.xyz>
 <20190826132904.3ayuw36qzl2c4ktr@development>
 <CA+TgmoaNOMG9+Ho9d3CX+-10O7+nqqvmSpXb1m0F3dqWB4C-8g@mail.gmail.com>
 <7361.1568738373@sss.pgh.pa.us>
 <20190917194510.iqwyl3be62pz7l27@development>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50"
Content-Disposition: inline
In-Reply-To: <20190917194510.iqwyl3be62pz7l27@development>
Precedence: bulk


--hHWLQfXTYDoKhP50
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 17, 2019 at 09:45:10PM +0200, Tomas Vondra wrote:
> FWIW I agree with Andres that there probably is an actual bug. The file
> should not just disappear like this, it's clearly unexpected so the
> PANIC does not seem entirely inappropriate.

Agreed.

> I've tried reproducing the  issue on my local systems, with the extra
> sleeps between fsyncs and so on, but I haven't managed to trigger it so
> far :-(

On my side, I have let this thing run for a couple of hours with a
patched version to include a sleep between the rename and the sync but
I could not reproduce it either:
#!/bin/bash
attempt=0
while true; do
	attempt=$((attempt+1))
	echo "Attempt $attempt"
	cd $HOME/postgres/src/test/recovery/
	PROVE_TESTS=t/006_logical_decoding.pl make check > /dev/null 2>&1
	ERRNUM=$?
	if [ $ERRNUM != 0 ]; then
		echo "Failed at attempt $attempt"
		exit $ERRNUM
	fi
done
> Yes, it should be moved to the older section - it's clearly a v11 bug.

And agreed.
--
Michael

--hHWLQfXTYDoKhP50
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2BgScACgkQnvQgOdby
QH1Jrw//W0g89WVt24FO698+ToX3Y/R8PaL+L9utzVwjfE3q4xC4uFYik2YNlqcA
u8TRPyc3OiBO7AdJUwFk/xxyZJyF1RQ76itp/R7xx6+ZDW7f09zIbih0KWyqmjEo
5B5NSMn11Pbqz1f3qd7Vb9sGp+XaHLTVLewDwAMyOol6h29YqHcF/aFoRIHW3XCo
BIc7zlazQhEe/ZD6MipOQaGUEyn4MTS1bA+XFxMzdpWAJxOVsnLBp8O+990hagme
0eRonq5LihXEDqGbist0O6wlfkDmW2bszZ7mayVxjoLH7MF8YVEjppj27zisD1xw
qONx5NzRO8aKddwiel16+6CLqBjbBfIDKghkM8SOhM+b2flFe7cfp7pg8Q+zAPAc
YdA7JzmtnARlpB2lLb0qBbvZUxlJ/H/WC4IpdTzOhFWl0yWbniygXfyZmiH3fUSW
TQ7GWbuS5CPMsAu65sBBtjjVcpnPV7QbfF1F/n9w9AL3mc/hCEQx5G6zmAD4OR9d
+qudLhtnz1VNQIxhua8DpUgjHcJTJ+mOKLwavy+AWWd7F7nneCJN30wM5V0kdhXv
FiJ+CcrcU/kkE2DZGh0N/Y9d9I9UAkocRn5f89uN23v9Ppnl47Ok7p5QNhyVGpAZ
n5Y8kXbAbVz5bdNoG974Yvi5pglB9ZjRKIUxmZy14YHezX3sISY=
=2aWO
-----END PGP SIGNATURE-----

--hHWLQfXTYDoKhP50--