Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAb40-0004Ku-Dj for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Sep 2019 14:36:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iAb3z-0002Ov-8W for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Sep 2019 14:36:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAb3y-0002Ob-Sz for pgsql-hackers@lists.postgresql.org; Wed, 18 Sep 2019 14:36:11 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iAb3w-0002T9-BC for pgsql-hackers@lists.postgresql.org; Wed, 18 Sep 2019 14:36:09 +0000 Received: by mail-qk1-x742.google.com with SMTP id 4so8256129qki.6 for ; Wed, 18 Sep 2019 07:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=5IKm0xdGuJgqv0CiDgIDMHgHPSkdTOAIGuToIQd23fk=; b=0s6lA3PxDIURy0nFo/NuNoac846i0qRcqhhSIksdTwlw9qMVmqPPZrOyr4luC0Y9CU X7iqgHgUw8g+gOKZAZwOB5+A7Vs+7JfOMJUgmkA5767NRoi8nu3kKNUdgFuo48O09agz hGoYm5EdWUjcV7vcgMHjiyT8/rcXGbTCYlTzxvnZPsYivz/ZOoIxAs2Fq9C0izhYcB6R jVBkESTg0aW0j/0hJk85JlLNkBQ1bqv9v7qV+9O/pLDUPjK8S62TL+0976z2FTbg+FDs QCj2nk75mEcxjxboWN1fgiYGUWluYJMz/e8cn0/0Qs2GkwuI5G2macssrPuCnwg5y73M QGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5IKm0xdGuJgqv0CiDgIDMHgHPSkdTOAIGuToIQd23fk=; b=EWK88WZ2vId+bnQjzkl5Mq9jpcYAPgXnttE08nw+TGKSpdb+IlZvPr6lxLQnFQk5yh 8EFqQnxivLNPdNyVwvmTEeVSwrKSqVxTXy+jLHfmyebHphaVN3OS9qna+Z3bXkXAZduL qIsTWhG1N43H5mApP1bDg8fz5WvXK3At01WtLKpi/CBwCCpxorrVUSI/U+Hm/TBuD6Nq XI9jdRl1oCtPhERdb/AwKFfq4fNWvG36bhyHzvQ5KyVLAmDxvQRK1AoVeM1jgqQPsNpJ AOKhkBlTc1bz2FUxON+tYXGYPcT+QNFaL59K9+79QEZuHbPrxJ2T1IttIfxZfEn0e3e1 aWSw== X-Gm-Message-State: APjAAAVa9j72vY/iI62LLhQLdhsow8uU4tmXVt1bFdx81mSsQo2i1xiM JFjouZken2Gl6PhG6+J73GKZeysnwFrcxNfsf5lrNENM+lhmt1XkyurErE/Gjg3iuBKBARnUO71 BpUfvwhakbeppNZ9xv+C3tjCmXb33+av/u/WPq2lvRI5/QqLEhdz6fdu33cDhUtx1VjfxiibXww QnaEvoH3aSEkd73/3n X-Google-Smtp-Source: APXvYqxI9TD8Jikw3sUj390zNBIx27S4AMN7xEXPAXbn7vx22/UAILGLWe5CXL511Ohre0sTY8XKDw== X-Received: by 2002:a37:b403:: with SMTP id d3mr4061082qkf.76.1568817367185; Wed, 18 Sep 2019 07:36:07 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([177.154.145.99]) by smtp.gmail.com with ESMTPSA id l7sm3249907qke.67.2019.09.18.07.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 07:36:06 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id E4F2A120349; Wed, 18 Sep 2019 11:36:00 -0300 (-03) Date: Wed, 18 Sep 2019 11:36:00 -0300 From: Alvaro Herrera To: Marina Polyakova Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner Subject: Re: pg_upgrade check fails on Solaris 10 Message-ID: <20190918143600.GA4211@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Sep-17, Marina Polyakova wrote: > Hello, hackers! > > We got an error for pg_upgrade check on the branch REL_11_STABLE (commit > 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the > argument to the sed command is not enclosed in quotation marks (see [1]): Hmm, I'm surprised it has taken this long to detect the problem. > Attached diff.patch fixes the problem. I have pushed it to all branches that have src/bin/pg_upgrade (namely, 9.5 onwards), thanks. I hope this won't make the msys/mingw machines angry ;-) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services