Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAloE-0005d6-OW for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Sep 2019 02:04:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iAloD-0002fd-L8 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Sep 2019 02:04:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAloD-0002fU-Bn for pgsql-hackers@lists.postgresql.org; Thu, 19 Sep 2019 02:04:37 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAloA-0002mz-22 for pgsql-hackers@postgresql.org; Thu, 19 Sep 2019 02:04:36 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 04734749; Wed, 18 Sep 2019 22:04:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 18 Sep 2019 22:04:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=3uoUPfBOtv/7TJj4UrlPizcGg1p PFIR2xFm2zudJMUU=; b=JEYZH2NX5/Ml1Dhl9oZhBiv8yJwBHIzlBQxETxKMiCT r2sNV55Rv8WgN6bdOX2eUByl4QEr5lybFD1hzH8lxOgcWmziCPAdX41WZPST5F7y abuLvoo1e0uv+n4QN4EqWl4uX08kMVdXnhOeKlb+0XmJEimHNfTT9tkZUDoPUJ+a yWhKntpB4Q1/nc7yfNSzK13GCIdQpq30+u7PBB1QGIFNCMRmO6WFmdOZPmqKRfaU laJGX23cD9IK0wlyxIvDPx8JlzOtHRoKCVAndJi2/EJ1ULEkWGW4sLkUrDM5z17F TVI8HXZsdxs3/vxk/BC60khdBuFT2IC0Y3hZ/q4JKKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=3uoUPf BOtv/7TJj4UrlPizcGg1pPFIR2xFm2zudJMUU=; b=pvMI+CFSxv6tdMKu6ZeKMz /sVDbmcFYcZ2xjZhyuBP9DEWJHe0LfaHk5gdxo/43XwCvr3Acw0JxCRNvx1F1jwi g6phitSYeXNlAgSdj9tad8eJVnm3295MoiflE/quahxI3Pdns8N7rUwKBI07d7i8 537Q2IhLzIE+J0MJDMwEISaWloTsqG7Qx4l0fDIxtwNeRMRZZVKGrKNypCo56uGl GGNi4jWNLrBdOJl9/far0FDnSEUNhkBozIfEVGjqJ8AUtRb/FeIPxXW/VxxDGiql InPOcK+x0GkVh9PnlxTVdakIP5C3ZRJkX3iTq0AANEptwbw0XjTeQqvqXK17iuqw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id CB90780066; Wed, 18 Sep 2019 22:04:25 -0400 (EDT) Date: Thu, 19 Sep 2019 11:04:22 +0900 From: Michael Paquier To: Amit Kapila Cc: Alvaro Herrera , Masahiko Sawada , Craig Ringer , Ashutosh Sharma , Julien Rouhaud , Peter Geoghegan , PostgreSQL Hackers , Abhijit Menon-Sen , Peter Eisentraut , Pavan Deolasee Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks Message-ID: <20190919020422.GD22307@paquier.xyz> References: <20190916134056.GB6026@paquier.xyz> <20190916141106.GA10690@alvherre.pgsql> <20190917004417.GA1660@paquier.xyz> <20190917040618.GD1660@paquier.xyz> <20190918013727.GH8909@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tNQTSEo8WG/FKZ8E" Content-Disposition: inline In-Reply-To: <20190918013727.GH8909@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --tNQTSEo8WG/FKZ8E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 18, 2019 at 10:37:27AM +0900, Michael Paquier wrote: > I am attaching an updated patch for now that I would like to commit. > Are there more comments about the shape of the patch, the name of the > columns for the function, etc.? Okay, I have done an extra round of review, and committed it. -- Michael --tNQTSEo8WG/FKZ8E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2C4iYACgkQnvQgOdby QH2FgxAAgPKaveymsA0AGMOFhvPKZ1e9s116MGd7t/UovbxgkF/6pn3VqL1+r9Jb A8W2iGgXsU7oWhILYRxW7/2tn462lCVEB/UtT4muGZoR9Z6LUezsiZuxxYhpABrQ AjFGfq6qXWLHlbAUX0MG/YyJWTZMZEGgwwEOJr4zkcxbXD2NS9UkkIL85IUNHJ32 es3sDaLsldlRFFVtq6CxRdPfs2q6eSdTLUTHig65uXswJfZ58msFyhyCnHmmW+Bf He7KtRxRK+IwivZv9RmQZQi/q+/YrSeJe7qKuQg0gtL1C9+lco9u2YbJBfTR3f8t UfEy43f1DhArUo1fm+EOQ4T5E9woytCAav8mykaIbfW/jGCuVyyKdmMSXvnkCLMl 6FrJ+EgBuTWlwcu8sVmLtEQdB5pkic5ryM9GXgQfAEwNLG2jw6jpHpRrIO7uxz1I aGnvy1KN0YYFnoxtnPIkPlFkg4YFg+cyS+eQJC0cEdclf1yqM7RimU0fCNnTo0bS X4kp+sdyC3MiDI5ARZWCF9lT8vuMtZIACPtokSpL3VilbWH7q2nexbxmMapZv6PW IiCREW6P/FY7bMIGLuGuPKfAQHg/afYZ9tfzV7KCqKhG1U7vzAGCN58/9bLGZtsm LgwK+f6u5rQlQJAZUgUD176UiR7WaQFUokYOFToBYswonBC3R1U= =XqqD -----END PGP SIGNATURE----- --tNQTSEo8WG/FKZ8E--