Date: Mon, 23 Sep 2019 22:25:54 +0200
From: David Fetter <david@fetter.org>
To: Tels <nospam-pg-abuse@bloodgate.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Efficient output for integer types
Message-ID: <20190923202553.GM31596@fetter.org>
References: <20190918034201.GX31596@fetter.org>
 <20190918.162746.139473050.horikyota.ntt@gmail.com>
 <20190920191450.GD31596@fetter.org>
 <20190920210916.GF31596@fetter.org>
 <20190920211813.GG31596@fetter.org>
 <87h856pekw.fsf@news-spur.riddles.org.uk>
 <20190921060835.GH31596@fetter.org>
 <87a7ayp4bm.fsf@news-spur.riddles.org.uk>
 <20190922215804.GL31596@fetter.org>
 <9cb0b9d6d98472d7d56dd6f78e9b40d4@bloodgate.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9cb0b9d6d98472d7d56dd6f78e9b40d4@bloodgate.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Sep 23, 2019 at 10:28:09AM +0200, Tels wrote:
> Moin,
> 
> On 2019-09-22 23:58, David Fetter wrote:
> > On Sat, Sep 21, 2019 at 07:29:25AM +0100, Andrew Gierth wrote:
> > > >>>>> "David" == David Fetter <david@fetter.org> writes:
> 
> > Fixed.
> 
> Good work, more performance is sure nice :)
> 
> Noticed one more thing in the patch:
> 
> > -		*start++ = *a;
> > -		*a-- = swap;
> > +		memcpy(pos - 2, DIGIT_TABLE + c, 2);
> > +		i += 2;
> > 	}
> > +	else
> > +		*a = (char) ('0' + value2);
> > +
> > +	return olength;
> > }
> 
> The line "i += 2;" modifies i, but i is never used again nor returned.

I found a similar one in a similar function, and removed it, too.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate