Date: Tue, 24 Sep 2019 11:07:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <pgsql@j-davis.com>
Cc: "Jonathan S. Katz" <jkatz@postgresql.org>,
	Stephen Frost <sfrost@snowman.net>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Add "password_protocol" connection parameter to libpq
Message-ID: <20190924020716.GD2012@paquier.xyz>
References: <4863222980d349a6251065ea67f00ac41dedb162.camel@j-davis.com>
 <20190821071224.GA26424@paquier.xyz>
 <fd9b2130bb4140676f4f9c5e5baf1393d826e3ab.camel@j-davis.com>
 <20190906070501.GF1608@paquier.xyz>
 <54d4b3ea8ed20690fad43a988aabe897864db888.camel@j-davis.com>
 <20190917070414.GH1660@paquier.xyz>
 <130e2ca6a081e8352d21d386efd54d7329849e45.camel@j-davis.com>
 <20190920040724.GJ1844@paquier.xyz>
 <941f7e6ab8edcd5cc467dfb90c96f6ae312c1e39.camel@j-davis.com>
 <20190921022430.GB1935@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1Ow488MNN9B9o/ov"
Content-Disposition: inline
In-Reply-To: <20190921022430.GB1935@paquier.xyz>
Precedence: bulk


--1Ow488MNN9B9o/ov
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 21, 2019 at 11:24:30AM +0900, Michael Paquier wrote:
> And both make sense.
>=20
> + * Return true if channel binding was employed and the scram exchange
> upper('scram')?
>=20
> Except for this nit, it looks good to me.

For the archive's sake: this has been committed as of d6e612f.

-   * We pretend that the connection is OK for the duration of these
-   * queries.
+   * We pretend that the connection is OK for the duration of
+   * these queries.
The result had some noise diffs.  Perhaps some leftover from the
indentation run?  That's no big deal anyway.
--
Michael

--1Ow488MNN9B9o/ov
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2JelQACgkQnvQgOdby
QH2kCA//e1+DmV5+9QmGFgLrs1QfIFqVU9w92xSxAV9OP0l6/HFKkwvM5tmk2WB9
SNQDkPcidhJiQnomki3kN0sbIbbWo3IR+b24ZITNUOPNSQWviCQojGCotgZc+/Dv
XWdWY8xWLwcs3S1T2m5o+nco6zYjDlgov0227AQAJHb7tSnnZYwi5U1jQ3zNVHhq
5SZCnQGsm8GqDgBoGcQaJoxaeywjVbjiWt2hFHgODBFXjy4u8oMaNKUswtDk77SX
BaAnLp+JMNKzBg2noniMr9DarRlG/Li+wB4edrFStV+r+XtGqzMHqNewKZMW6gwZ
3i6SWXuWK4UGjvcUcwA8sqD3H1i1KW/XchQkHKsVNfMwW1CnLcRHIF5b/5AX//ae
d2zO4e0yYxiZiqRcubiNaajq947Oa9BjblIMjG3OjAalbfH1SqjaOc01/D0avWo6
hJ2s+o0A5gBt8XzxN/a7lFP3NU9qAZ8qvlMarbUYOkesdZfi+9Fp81QoYmmtYMxO
s3aeQygvXaPyQtSo4FkLrN9byrEFfpJsYHK60FdOUE983rB8OnkXPD5ExMA9BkFU
NJWnJtCEpLJ0WjKbjixGDAlsakYLoXh6AnNj4Qjz50AgY/er2PT4eHZsFCX1yZvV
VrkZsacxnrHG95VmjrywLt9nflRPe9YRJ2ilSaIlDbIIr82YgwQ=
=xlxz
-----END PGP SIGNATURE-----

--1Ow488MNN9B9o/ov--