Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCrAd-00018R-M7 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Sep 2019 20:12:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iCrAb-00023H-MF for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Sep 2019 20:12:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCrAb-000239-B4 for pgsql-hackers@lists.postgresql.org; Tue, 24 Sep 2019 20:12:21 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iCrAY-0001K6-QB for pgsql-hackers@postgresql.org; Tue, 24 Sep 2019 20:12:20 +0000 Received: by mail-qk1-x741.google.com with SMTP id u22so3132706qkk.11 for ; Tue, 24 Sep 2019 13:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=KWIq5h4j7hOo0XzRNEPosktObmD/Mv/JIx0scaKY0QA=; b=i++X7z3+qQnbHbf+aGGMcvmvNCRxkfId5mAPvlnMdF8hQbUyrOXEvryCGnmkE4e7CU fMTEYt32nrOqRrnXULLlrgbQnV6laK6lvMybGBMtfmzeNFvCQ2dB2QI7lMiTqWNL7NRH YkRBGgKBqkS6beb6vcy1m1nzN7R1p1x/ppLmeM1Tv+ZU6IWoRyVpLfsNZwLzhD/bmGH3 bRXE4p6BQbQADb8aiU5om6HO1zm0z30HSLalCbpOdNdqOvGBMDKD8sAKH2AGgn72ztrB a0h6qt3aJ/BVhKf9YXtXzPsuMII8tufx0O90QS1pp1+u0oLCyedVlDlNR76nFrNRlwln 6hvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KWIq5h4j7hOo0XzRNEPosktObmD/Mv/JIx0scaKY0QA=; b=VeCkO8SOono2+O4rvEXXasi51JkKM62cj5pG2oXtanllbH3Q4IkVjtXJlTRw6ONKuH eZtg5QcJDAALTfTzMXAaRHpTGYOJLB+/yjHjIoXNYueuROrwe0TpWUFXu4hIUAvobTbr JlZ9zYBsbXz9nqHQm4zP29Nn1oyUATrS3TyBlL/VNbejQEuZKXzT5H87+CiVZ0N0HzoH pJ35pR8H98ATB3y7m12zXQVVtFMIpT1L3C+xgTj3fWRoJhSK7/twVs1x/JGsviXLSfM8 05uHns1yxTr0wb3CRj0/aHbI/hjTIDPTb54VzacCUY0A/FHDsjtQ+rCpFK8Muw8NTiaf eB8A== X-Gm-Message-State: APjAAAWE277VlHthXDRO10gi1PFgB0lXnHxu3X4Zc9ayxgoRgdalpZAO WAVLg2IvJpad5/7Hbz4Zh8hnSg== X-Google-Smtp-Source: APXvYqy7Ij9Q6AbJkOxcKHwPfoN5DPcI5Vz7UqR3vJZUKmQwCtWfYnG0CR/xWtv3cyCyvqUsNMQ+9w== X-Received: by 2002:a37:713:: with SMTP id 19mr4512795qkh.490.1569355937976; Tue, 24 Sep 2019 13:12:17 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id z38sm2122948qtj.83.2019.09.24.13.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 13:12:17 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id D3DDC12069D; Tue, 24 Sep 2019 17:12:14 -0300 (-03) Date: Tue, 24 Sep 2019 17:12:14 -0300 From: Alvaro Herrera To: Paul Guo Cc: Michael Paquier , Thomas Munro , pgsql-hackers , Jimmy Yih , Ashwin Agrawal Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) Message-ID: <20190924201214.GA12389@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Sep-20, Paul Guo wrote: > The patch series failed on Windows CI. I modified the Windows build file to > fix that. See attached for the v7 version. Thanks. Question about 0003. If we specify --skip-clean-shutdown and the cluter was not cleanly shut down, shouldn't we error out instead of trying to press on? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services