Date: Wed, 25 Sep 2019 12:13:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, pgsql-hackers@lists.postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>, Dent John <denty@qqdd.eu>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions
 from inside of access method
Message-ID: <20190925031355.GD1815@paquier.xyz>
References: <9629467.uHNm3GW8oi@x200m>
 <20190924153830.GA26314@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tEFtbjk+mNEviIIX"
Content-Disposition: inline
In-Reply-To: <20190924153830.GA26314@alvherre.pgsql>
Precedence: bulk


--tEFtbjk+mNEviIIX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 24, 2019 at 12:38:30PM -0300, Alvaro Herrera wrote:
> On 2019-Sep-24, Nikolay Shaplov wrote:
>> =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=B2=D1=82=D0=
=BE=D1=80=D0=BD=D0=B8=D0=BA, 24 =D1=81=D0=B5=D0=BD=D1=82=D1=8F=D0=B1=D1=80=
=D1=8F 2019 =D0=B3. 9:25:54 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=
=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Alvaro=20
>> Herrera =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
>>> 0003 looks useful, thanks for completing it.  I think it would be a good
>>> idea to test invalid values for each type of reloption too (passing
>>> floating point to integers, strings to floating point, and so on).
>>=20
>> We already do it in reloption regression tests.
>>=20
>> My idea was to test here only the things that can't be tested in regress=
ion=20
>> tests, on in real indexes like bloom.
>=20
> I suppose that makes sense.  But of course when I push enum reloptions
> I will have to add such a test, since bloom does not have one.

Good point.  We rely now on the GUC parsing for reloptions, so having
cross-checks about what patterns are allowed or not is a good idea for
all reloption types.  I have added all that, and committed the
module.  The amount of noise generated by the string validator routine
was a bit annoying, so I have silenced them where they don't really
matter (basically everything except the initial creation).
--
Michael

--tEFtbjk+mNEviIIX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2K23MACgkQnvQgOdby
QH21jw/6AuFbA+P/UHTHohXhgVJacMqLbp59Sgal75CBCeyChq0tFxgViQTN+BK9
1rx6Q8Do5RU14rA+i14jujXfUAkWSaARljJ3/wd0DteLxigblm0uQ/e60Qp/CgVD
j0CyyOPy8ALybo7P0GZwO0ankSW3d36E0O7Wv62VjV8zLN/r/l7VxBGjLv1KNlEj
STgYL4V2nQE/kNNMbZ1AU+FiAgcT2hCUTib+ZbaxbCoBhoeGv6NTxYaU3J4NFTH/
5D4hOxmxK7c77j7GmC1PWF7YUjxB4A7NzeYoEgbkRlKXoF2tRvxw4W88acXKz7kB
BZUaoJwCmlPjvk0fTJZSrwIGQJZyHiUNOD2WZId3A7WRSEcMwT6pZkYCvDRYi1Le
NWA3BIvl607tBGAiKhI7yZ8Lwv7nmN5W5J60C+UfYZCXPZQhpGNZdmUMg6D2UWKP
2yPknUm835+w7PEGe1OdBaqX2rb/q3xcqotnwRHsVkIy/oiA9lKo+AnBt6HvAJRw
5d1PvPYYRVHFWsaav5ltyUmtatbNbloaecj6xv/38dLJMoNvcncnBox9Vwra/G5t
XnSuyOvw8d+/QzayByZZVbfk2tDDx0h6BNa2nv1qxYlWHMgO6UiE8eYbW1OfoZna
DhAOgCHm3nAbGmuSDbiZfvNTzQGkVPP4nddky3TNKjEcWcYqIuc=
=K3wA
-----END PGP SIGNATURE-----

--tEFtbjk+mNEviIIX--