Date: Thu, 26 Sep 2019 22:22:13 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Race condition in logical walsender causes long
 postgresql shutdown delay
Message-ID: <20190927012213.GA10253@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAMkU=1xd2w6OmgHb_fCQW3-gHOswAEThqgkbZ=WLU_qbcok4Lg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Sep-26, Jeff Janes wrote:

> On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
> 
> > Reading over this code, I noticed that the detection of the catch-up
> > state ends up being duplicate code, so I would rework that function as
> > in the attached patch.
> >
> > The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
> > I'm not going to change that in a backpatchable bug fix.
> 
> Hi Alvaro, does this count as a review?

Well, I'm already a second pair of eyes for Craig's code, so I think it
does :-)  I would have liked confirmation from Craig that my change
looks okay to him too, but maybe we'll have to go without that.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services