Date: Mon, 30 Sep 2019 10:58:52 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Online checksums patch - once again
Message-ID: <20190930145852.GC8385@momjian.us>
References: 
 <CABUevEwE3urLtwxxqdgd5O2oQz9J717ZzMbh+ziCSa5YLLU_BA@mail.gmail.com>
 <20190926194828.GA17211@alvherre.pgsql>
 <CABUevEyTp8OKUxV+-id0PLoB0sA+7d2uefAzYnq=Kb03V5r5PQ@mail.gmail.com>
 <20190930124944.vn2c2y44ybxck6wa@development>
 <20190930145313.GB8385@momjian.us>
 <CABUevExL7VaUTm17qzw7PS64Uhopcwy+crMZqHPi-YkqgjUJzw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CABUevExL7VaUTm17qzw7PS64Uhopcwy+crMZqHPi-YkqgjUJzw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Sep 30, 2019 at 04:57:41PM +0200, Magnus Hagander wrote:
> 
> 
> On Mon, Sep 30, 2019 at 4:53 PM Bruce Momjian <bruce@momjian.us> wrote:
> 
>     On Mon, Sep 30, 2019 at 02:49:44PM +0200, Tomas Vondra wrote:
>     > On Mon, Sep 30, 2019 at 01:03:20PM +0200, Magnus Hagander wrote:
>     > > Other than bots, this patch doesn't seem to have attracted any
>     reviewers
>     > > > this time around.  Perhaps you need to bribe someone?  (Maybe "how
>     sad
>     > > > your committer SSH key stopped working" would do?)
>     > > >
>     > >
>     > > Hmm. I don't think that's a bribe, that's a threat. However, maybe it
>     will
>     > > work.
>     > >
>     >
>     > IMHO the patch is ready to go - I think the global barrier solves the
>     > issue in the previous version, and that's the only problem I'm aware of.
>     > So +1 from me to go ahead and push it.
>     >
>     > And now please uncomment my commit SSH key again, please ;-)
> 
>     For adding cluster-level encryption to Postgres, the plan is to create a
>     standby that has encryption enabled, then switchover to it.  Is that a
>     method we support now for adding checksums to Postgres?  Do we need the
>     ability to do it in-place too?
> 
> 
> I definitely think we need the ability to do it in-place as well, yes. 

OK, just has to ask.  I think for encryption, for the first version, we
will do just replica-only changes.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +