Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iEzFG-00004x-M0 for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Sep 2019 17:13:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iEzFF-0001YV-Gv for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Sep 2019 17:13:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iEzFF-0001YI-18 for pgsql-hackers@lists.postgresql.org; Mon, 30 Sep 2019 17:13:57 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iEzFB-0002z8-O9 for pgsql-hackers@postgresql.org; Mon, 30 Sep 2019 17:13:55 +0000 Received: by mail-qt1-x841.google.com with SMTP id r5so18026338qtd.0 for ; Mon, 30 Sep 2019 10:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=l7Jm5VO7kTEzylhygmR4LFV1Ud42U05kdA+Dl5tUvgw=; b=tTqFpBvApmshZyBjzCszPiGBNaH4xq9s9bAOV+sVjda7HXLz7gKiZ+CyoZviLdUNwp 6bUA2Htqkcq79BBjlWFcdaDwgCPfQ2qPZnarRYQrVHT6uzppVV/y9nQSgwCf33qc9hLO l5uzSp2BqTy43uETy41LUqXEWk3L5YZigLVgiviy4WuR6qyzWoCVqLJxOshvQQzWpVFR d2lmIDFnri/Gwu3nmDUoqhOiUkjus/5fZzndT4n+Comp0u+nm+Mw4WNNlXzWxX2Gu62R gXYPJQ5CZYo0vZJaGmC9e43GMuExagxeLm4272wLopFVuu59g8VuYtgkVUWOgr1KjG/L cGYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=l7Jm5VO7kTEzylhygmR4LFV1Ud42U05kdA+Dl5tUvgw=; b=skqAj5GkbKmwwZLCGgXCJHQE7TDBrFMYge2IqJlBr2s23IxCoAIS/+pSRWAgkFem6c /YfSx8Isiy+Hp/VDjLaOPWy+yHJMYA1ZD1FhZsdO0I2YlyVj8tTLbkLpSIcKCQMU4QCS AqiDslzE+v/+h/S5iICzUFGb/nXBZcGsGHhn1apojXi1Ys1gBBpAZVXQzY/N6w/O6WqH pq7zk8wnyJq4ijKykwZcoiRxsKYKf7TmRjmj52xO5iM0tRNR0g/mOcquDgPklp36Y6GB /0OVc0NTKmMRD+9itCiJPs2QBBzwhtDwS4Ld0KYGaSMF3nQKJCNMurPksWqFT/JvqBMI HgkQ== X-Gm-Message-State: APjAAAXA4w12v3Odt8UDlViHxCU3MS9gjmWdrQyJ7vXt7AagKFTij8/D cf7XH7J0Z8nZRSeStdFzf7MHnQ== X-Google-Smtp-Source: APXvYqzFghKh7ZeWaht2bHjOtO0DqBGnHtW3+K/3+0TTfSHw0nrTzYdj3Bs57vx/KqQje2Gw6XcClw== X-Received: by 2002:a0c:98b8:: with SMTP id f53mr20974196qvd.157.1569863632648; Mon, 30 Sep 2019 10:13:52 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id z6sm5780492qkf.125.2019.09.30.10.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 10:13:52 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 706C5120E27; Mon, 30 Sep 2019 14:13:49 -0300 (-03) Date: Mon, 30 Sep 2019 14:13:49 -0300 From: Alvaro Herrera To: Paul Guo Cc: Alexey Kondratov , Michael Paquier , Thomas Munro , pgsql-hackers , Jimmy Yih , Ashwin Agrawal Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) Message-ID: <20190930171349.GA21905@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk OK, I pushed this patch as well as Alexey's test patch. It all works for me, and the coverage report shows that we're doing the new thing ... though only in the case that rewind *is* required. There is no test to verify the case where rewind is *not* required. I guess it'd also be good to test the case when we throw the new error, if only for completeness ... -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services