Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iL5hC-0003hm-Ir for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Oct 2019 13:20:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iL5hB-0005QV-9P for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Oct 2019 13:20:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iL5hA-0005QJ-Mt for pgsql-hackers@lists.postgresql.org; Thu, 17 Oct 2019 13:20:01 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iL5h7-00084f-FQ for pgsql-hackers@postgresql.org; Thu, 17 Oct 2019 13:19:59 +0000 Received: by mail-ed1-x541.google.com with SMTP id c4so1732820edl.0 for ; Thu, 17 Oct 2019 06:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=FQcJuJmM/Ke4dh84CTyittJrgnS+XSaqnL8/5Vw5Se8=; b=sTJQGjuNANmcBrsKZqJNRDqZPfjXnaVC8K5muBfISXzRfEDY8ki5a4pb6LtE4dELfH HmGrI8dXpQ1axXph5eZfRW3/GSs6DUI+zlPYntMvBfwOz3r6prZir+r7nAxklz0MEqOF Bu+09zN4VqdncZ0Wo2z4mjBWC9hSoyCdQp9+gNVBWm8xJfjF8xyIQswDaXX9yS5vWckQ oc12/TYPpCnlLfhFycE0uh7suRmHSo+Da95K1OthpkC/ApJtc4kzOvQoffxEk1eHCQQa MQQ2dSRxGdn7Mso6lBvN5XqAr+l4zglL0HLacg/HFD2NXqNFsPGTiiNKrPObtI+hM40c kXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FQcJuJmM/Ke4dh84CTyittJrgnS+XSaqnL8/5Vw5Se8=; b=WFaVb63IsD4zIcNRliJYasfa4QP2LIVGkyiOgcUvMndxq716LNlhZ28CniUVnITcTH D54ujogmMwBbovVuIyGXkySJNvpnf91fHOPI89eIkjzZZC95GQx74thphh6Mr7URkijm 17Fzr2UqwAblERKS3oJH+90wpcgNp9N1pfne3gI8yemyoFGm8PP00NtPKTFulsWO2+1q IDm/yeh+izv9Vf0TxKZe9yIg+c2OnwvU8x5cf9zN37BDTqlSM9GPl/RzLqttPL/eUi9A DhgWhu1H0GpR1bM7uyOGfx8GAOWCSLxxxovj6N34r1JLNOj+zs8etxWhbOu3TJgNNupA bZPg== X-Gm-Message-State: APjAAAVNb80R9B2ioS93e2L5PmgOTa2N7jTYnh6B0wdDAMM5cCDLCFtT +HlnSHCVoZTB0qyAPjPt2AXh0g== X-Google-Smtp-Source: APXvYqzhMr7999wuzWMIDLI05Mgs0acoKjzVEbttWA88nCYnmFzQGBICjpQqp8NzgPb24+nnUCgJYA== X-Received: by 2002:a17:906:4895:: with SMTP id v21mr3472981ejq.2.1571318396102; Thu, 17 Oct 2019 06:19:56 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([82.102.24.174]) by smtp.gmail.com with ESMTPSA id j10sm109355ede.59.2019.10.17.06.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 06:19:55 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id A40C3300A24; Thu, 17 Oct 2019 10:13:59 -0300 (-03) Date: Thu, 17 Oct 2019 10:13:59 -0300 From: Alvaro Herrera To: Jeff Janes Cc: Craig Ringer , PostgreSQL Hackers Subject: Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay Message-ID: <20191017131359.GA6829@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190927012213.GA10253@alvherre.pgsql> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Sep-26, Alvaro Herrera wrote: > On 2019-Sep-26, Jeff Janes wrote: > > Hi Alvaro, does this count as a review? > > Well, I'm already a second pair of eyes for Craig's code, so I think it > does :-) I would have liked confirmation from Craig that my change > looks okay to him too, but maybe we'll have to go without that. There not being a third pair of eyes, I have pushed this. Thanks! -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services