Date: Mon, 4 Nov 2019 12:42:35 +0100
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas
 <hlinnaka@iki.fi>
Subject: Re: pg_waldump erroneously outputs newline for FPWs, and another
 minor bug
Message-ID: <20191104124235.02df2198@firost>
In-Reply-To: <20191030002621.GB1590@paquier.xyz>
References: <20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de>
	<CAH2-Wzn7Aw60HFvc=VrXpzqJAphPtuN2qLMj03FyyykMcBPMeA@mail.gmail.com>
	<20191030002621.GB1590@paquier.xyz>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 30 Oct 2019 09:26:21 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote:
> > The same commit from Heikki omitted one field from that record, for no
> > good reason. I backpatched a bugfix to the output format for nbtree
> > page splits a few weeks ago, fixing that problem. I agree that we
> > should also backpatch this bugfix.  
> 
> The output format of pg_waldump may matter for some tools, like
> Jehan-Guillaume's PAF [1], but I am ready to bet that any tools like
> that just skip any noise newlines, so +1 for a backpatch.
> 
> I am adding Jehan-Guillaume in CC just in case.

Thank you Michael!