Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iS7ho-0002bo-Fy for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 22:53:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iS7hn-0003f9-2V for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 22:53:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iS7hm-0003f2-Fq for pgsql-hackers@lists.postgresql.org; Tue, 05 Nov 2019 22:53:42 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iS7hj-0007FL-O9 for pgsql-hackers@postgresql.org; Tue, 05 Nov 2019 22:53:40 +0000 Received: by mail-pf1-x42e.google.com with SMTP id s5so8934160pfh.9 for ; Tue, 05 Nov 2019 14:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n8mI+nzoGQ93pGKO3PmUDm8YYKCj2fb8mHfBWYtdbFk=; b=U17iufud/DpME45/0ts7uPP4ZDqp9u+Z4q23760cPKD1XLUkwT4yjmVXa6wmC6ftjo BKTrgLNUxuzVAGLROnLwZ70RhbgJAHNCeeNTEGXhsNyg4LryNWYp5VaH7G57OrPLMue5 aC1u7bn+EalnMdg3AF04MDdoKgJ6/YFJwqNaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n8mI+nzoGQ93pGKO3PmUDm8YYKCj2fb8mHfBWYtdbFk=; b=uGHzp0HhtkESevsSnJMrXBWL1Ss12TFPdUbZ+/FgqS/0p8fyIRBHkZHxRGdaw9fJI1 W138zxAzornob+wbXHvaUsUEo5VM+zKXFewjC1wKQh1YtzEiXi4ldiHeonx35DW+9Iyh iXFgFBb7GYSkAfBRf297H4XC6p17KEzkvFQcmwQXk/QhT/jZJOfbNZ2l5LohKQG/g1Oi kaMvnADbdvznArc2DBPsOH513bjsk22Ql9BN7I7ProSDQsHzy9XZNAdAetmEF64VyeYU TnzCY0vgUpkUGbhnuB51sfnemkspQSK+3NAiGJqKaLQvKK9idb5pUu6V2korZJF1qGPQ yJ4Q== X-Gm-Message-State: APjAAAU3MAH36B1bFDgcJCeuWwvqndGGcVkrXPuKKdx6tZsOMrWbIdfk scmdke3XwTaCm7OEwY095JbYrQ== X-Google-Smtp-Source: APXvYqyH8b+rvnlu0HyiTwrpZxzPF/l/v7LM2L5O5Yo0KWTVA+/ifhoELopHfHtrnBP/KNMEir5jSA== X-Received: by 2002:a17:90a:6283:: with SMTP id d3mr1980611pjj.27.1572994418499; Tue, 05 Nov 2019 14:53:38 -0800 (PST) Received: from rfd.leadboat.com (108-233-125-46.lightspeed.sntcca.sbcglobal.net. [108.233.125.46]) by smtp.gmail.com with ESMTPSA id w10sm470562pjq.3.2019.11.05.14.53.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2019 14:53:37 -0800 (PST) Date: Tue, 5 Nov 2019 14:53:35 -0800 From: Noah Misch To: Robert Haas Cc: Kyotaro Horiguchi , PostgreSQL-development , Dmitry Dolgov <9erthalion6@gmail.com>, Andrew Dunstan , hlinnaka , Michael Paquier Subject: Re: [HACKERS] WAL logging problem in 9.4.3? Message-ID: <20191105225335.GA395764@rfd.leadboat.com> References: <20190828.154210.204505676.horikyota.ntt@gmail.com> <20191025.131251.322449872063947371.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Nov 05, 2019 at 04:16:14PM -0500, Robert Haas wrote: > On Fri, Oct 25, 2019 at 9:21 AM Kyotaro Horiguchi wrote: > > This is the fixed verison v22. > > I'd like to offer a few thoughts on this thread and on these patches, > which is now more than 4 years old and more than 150 messages in > length. ... Your understanding matches mine. Thanks for studying this. I had been feeling nervous about being the sole reviewer of the latest design. > Comments on comments, and other nitpicking: I started pre-commit editing on 2019-10-28, and comment+README updates have been the largest part of that. I'll check my edits against the things you list here, and I'll share on-list before committing. I've now marked the CF entry Ready for Committer.