Date: Wed, 6 Nov 2019 20:22:55 +0100
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Adrien Nayrat <adrien.nayrat@anayrat.info>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Subject: Re: idea: log_statement_sample_rate - bottom limit for sampling
Message-ID: <20191106192255.cbckgh6x5xday3sr@development>
References: <20190801100445.yo5v3pdxelijztzm@development>
 <3f6b75ea-03bb-7c35-1f20-e989f4b7f9ac@anayrat.info>
 <20190804191037.em6rmlvxjpcsjtqu@development>
 <25079.1564946172@sss.pgh.pa.us>
 <20190804195823.qi7vntgybfgitdnn@development>
 <27954.1564950312@sss.pgh.pa.us>
 <20190804204848.7f7ypsbijpgxojxx@development>
 <20190804214154.tbr5pbg5wss2adfu@development>
 <20191106182106.dwdvxalewyydqbx3@development>
 <3d67278c-3e8f-6ef4-4950-eb5e7a4411de@anayrat.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <3d67278c-3e8f-6ef4-4950-eb5e7a4411de@anayrat.info>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Wed, Nov 06, 2019 at 08:00:57PM +0100, Adrien Nayrat wrote:
>On 11/6/19 7:21 PM, Tomas Vondra wrote:
>> I've pushed the reworked version of log_statement_sample_rate patch [1].
>> If I understand correctly, that makes this patch unnecessary, and we
>> should mark it as rejected. Or do we still need it?
>
>Yes, the goal of this patch was to disable sampling and log all queries whose
>duration exceed  log_statement_sample_limit.
>
>For now it is possible just with log_min_duration_statement which log all
>queries whose duration exceed it.
>

OK, I've marked it as rejected. If someone thinks we should still have
something like it, please submit a patch implementing it.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services