Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSljy-0000rm-TT for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 17:38:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iSljx-0004ZL-KP for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 17:38:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSljx-0004ZE-8N for pgsql-hackers@lists.postgresql.org; Thu, 07 Nov 2019 17:38:37 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iSlju-0005xb-Py for pgsql-hackers@postgresql.org; Thu, 07 Nov 2019 17:38:36 +0000 Received: by mail-qv1-xf35.google.com with SMTP id cg2so1120657qvb.10 for ; Thu, 07 Nov 2019 09:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=8Wqv7MQWDO+xecQK3TMCq33ZNL6WZHq9vTPuZyc1W4Y=; b=ry3QMSdVk48UuX46Gvydm3uBtihZN5hP2hPEjMwtr1i1JBQrDeNCmUKRmJoGaypxvN 97/HrlcnT5yj/Px9JUuAoo/rEnz5kVJndaR3tL0OTK9BK1AVLNOEXoR3gkzKj80URWZm CsFcX8nwcG5rGPPflFhtEt8kFaXxiQcjqdyj35pg7Q9hVTE8DXHnJNlnNDB2HpvBDspB x298Sifejp2W9LcUM2dq15is0atPKEN/AMF87SvFsebO0jtcHt68RJqMMWuw5at1HATq nNXgDdTu79pNLCtkrjfZ3vm6zRImBkzU18OGi2BHbAg5qyc3vZ0FT48gCSDm4fJjlNhY ib4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8Wqv7MQWDO+xecQK3TMCq33ZNL6WZHq9vTPuZyc1W4Y=; b=mbyJnaAG9QMV/vTyBVMCvVLuGOkfx5M/ijFpJK/MklCKkFAeo2Z7i8aDMhnVoNemFy hn0qbZ83vteZyURz/D5NGzjFSlVuLBg31fh4Et7TGFdsFrNeO4XiHq/36d/j2MKv3mf1 lj1QS/cQpxVv4jh/0EdmC7eh2TiyRT8+kMdu1fU7Ty0qmqgWK6DQZzTVNGAqUtwvX6jJ 1G7ig+3mW0xcQ/XtEmeJsLDSL79o/1NhdUbNU+bIC91mCVKhpYQ+zDBGPKREGaCE8XJa h3POs2F3IaFUGbxEvd2reZ0f6CRH1AWd5HeGoYOZVRpS+nh4dicyWt4qsGvcm1jAaTST QtFg== X-Gm-Message-State: APjAAAVdg4mA1wHkjU7tbk/TFNGnBC2K5GlY6xQ5HHjeinu59RhE8fWx OyRCgjAUBE533Sc2eAFkodFRyg== X-Google-Smtp-Source: APXvYqw2G3rJ72CBhMY2F/F6TT+Ub6varWG28qrurOhDdiZ1pNIrwzM8/f5yLaYpO6Qx5NPm8y1Zfw== X-Received: by 2002:a0c:a998:: with SMTP id a24mr4449067qvb.117.1573148313880; Thu, 07 Nov 2019 09:38:33 -0800 (PST) Received: from nimloth.alvh.no-ip.org (ip-104-2-52-196.nyc.us.northamericancoax.com. [196.52.2.104]) by smtp.gmail.com with ESMTPSA id u7sm1374742qkm.127.2019.11.07.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 09:38:33 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 8FDF8302246; Thu, 7 Nov 2019 14:38:29 -0300 (-03) Date: Thu, 7 Nov 2019 14:38:29 -0300 From: Alvaro Herrera To: Mark Dilger Cc: Pavel Stehule , Michael Paquier , PostgreSQL-development Subject: Re: Checking return value of SPI_execute Message-ID: <20191107173829.GA19178@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1de13b09-a5a0-4c6e-0470-5ecebc0a7784@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Nov-07, Mark Dilger wrote: > I'd like to keep the status codes for (a) but deprecate error codes for (b) > in favor of elog(ERROR). I don't see that these elogs should ever be a > problem, since getting one in testing would indicate the need to fix bad C > code, not the need to catch an exception and take remedial action at run > time. Does this adequately address your concern? Yes, I think it does. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services