Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iWC54-00049M-Pc
	for pgsql-hackers@arkaria.postgresql.org; Sun, 17 Nov 2019 04:22:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iWC51-00072z-3h
	for pgsql-hackers@arkaria.postgresql.org; Sun, 17 Nov 2019 04:22:31 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1iWC50-00072s-Nm
	for pgsql-hackers@lists.postgresql.org; Sun, 17 Nov 2019 04:22:30 +0000
Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1iWC4y-0005lv-BY
	for pgsql-hackers@postgresql.org; Sun, 17 Nov 2019 04:22:30 +0000
Received: by mail-qk1-x742.google.com with SMTP id m4so11561484qke.9
        for <pgsql-hackers@postgresql.org>;
 Sat, 16 Nov 2019 20:22:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=ZqmJ5YG8gxKIiEX5nlulGcWD4elBibyoHT9sUFHKZ/Q=;
        b=St7u0fcEHKftq2NNKme2R1hWR0fulz87wwJBsANeRXyn/IaDX5CfK8V/s/LE5l2hue
         Q5/a9XPWn0dG7lUmpwE3DGA8Vl9KuC0E/wyCBPzWyFEm1TwE7TtEozEhlkOPmDrKF6P+
         tMm6+cW10SUZtPNXEK8CNjaByZAOVjSbjtqMPfdqnZDPK/WraRTiZGgoPS2jRzgVh1BN
         PkALaXi/I/EaXoLxSoSqFKcwSmxuYDawim/Jbqcjv6Ox7MFA/UfgTnSjLEtUUKp5a3mu
         kAv+nbnBTlJNaxyr+eBmJthqhcl2dCUzaoeD3rtxfmXH2ZRmn2gMjlgzSpXcoywVtzxv
         GZlA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=ZqmJ5YG8gxKIiEX5nlulGcWD4elBibyoHT9sUFHKZ/Q=;
        b=pDVJcS0EQOIZ2WnpF4BkocJCk+m3EqKbFskc3QokyJdRpOpOFV4yxn27ofdPAfJxn6
         iEEwHR2guIHmRx85vhMdomXd23nt5WZ6v/KsOyIvwWqXwxAzZ1IyX40Rq76eCD7kMu8Z
         odtZ2ENyJhbR/0iq61+le8AHztfV26VZFxmJTywnn1H79tTRy8SaGEa+EumimRNoAGFJ
         UHiskm9TFfw6J5JuN+6LSJDrtyagJ7m0othQRrSJfspKv5IrK9MWHjaoq/ucVhEO/m3/
         7PDY9Ii74KF5zsULjeHOmNHREaXgyFf4VFuUZBtIhkv9zz8LLS8OfN4zjCPkIQYH0KI1
         gojA==
X-Gm-Message-State: APjAAAWB32AgsVF8MsWSkC5VLNQA3ZrlaznX3jiF0OYcYOevFM3ph75h
	YumOHqGwL/FDZVvCTBJIVV5naA==
X-Google-Smtp-Source: 
 APXvYqzv2b82+yI0y3i0LflckcvPvUYjDdCb++sJnsmeof0uc5GquYSod2IaupdnQ6tj8W8HuQoIYA==
X-Received: by 2002:a37:ba44:: with SMTP id
 k65mr20244804qkf.169.1573964546214;
        Sat, 16 Nov 2019 20:22:26 -0800 (PST)
Received: from nimloth.alvh.no-ip.org ([190.95.19.128])
        by smtp.gmail.com with ESMTPSA id
 m72sm6594819qke.5.2019.11.16.20.22.23
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Sat, 16 Nov 2019 20:22:24 -0800 (PST)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id D904B30092B; Sun, 17 Nov 2019 01:22:21 -0300 (-03)
Date: Sun, 17 Nov 2019 01:22:21 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Attempt to consolidate reading of XLOG page
Message-ID: <20191117042221.GA16537@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <44237.1573556793@antos>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

BTW ... contrib/test_decoding fails with this patch.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services