Date: Sat, 23 Nov 2019 13:14:06 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: errbacktrace
Message-ID: <20191123161406.GA8050@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <26476.1574525468@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Nov-23, Tom Lane wrote:

> I had occasion to try to use errbacktrace() just now, and it blew up
> on me.  Investigation finds this:
> 
> int
> errbacktrace(void)
> {
> 	ErrorData   *edata = &errordata[errordata_stack_depth];
> 	MemoryContext oldcontext;
> 
> 	Assert(false);
> 
> 
> I suppose that's a debugging leftover that shouldn't have been committed?
> It did what I wanted after I took out the Assert.

Uhh ... facepalm.  Yes, that's not intended.  I don't remember why would
I want to put that there.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services